Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.2] ✨ ClusterClass: use exact versions from ClusterClass, stop api bump in CC #7306

Merged

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
Manual cherry-pick of #7231

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 28, 2022
@sbueringer sbueringer force-pushed the pr-1.2-cc-pin-version branch from d3832ad to 2814401 Compare September 28, 2022 11:19
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @killianmuldoon

@sbueringer sbueringer changed the title ✨ ClusterClass: use exact versions from ClusterClass, stop api bump in CC [release-1.2] ✨ ClusterClass: use exact versions from ClusterClass, stop api bump in CC Sep 28, 2022
@sbueringer sbueringer force-pushed the pr-1.2-cc-pin-version branch from 2814401 to 289b6cc Compare September 28, 2022 11:28
@fabriziopandini
Copy link
Member

/lgtm
/approve

this qualifies for backport because version bump in CC doesn't work and users could end in weird spot in an apiVersion changes for providers

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 28, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@k8s-ci-robot k8s-ci-robot merged commit cd0d608 into kubernetes-sigs:release-1.2 Sep 28, 2022
@sbueringer sbueringer deleted the pr-1.2-cc-pin-version branch September 28, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants