-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ ClusterClass: use exact versions from ClusterClass, stop api bump in CC #7231
✨ ClusterClass: use exact versions from ClusterClass, stop api bump in CC #7231
Conversation
ceea81f
to
43ee995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
quick, pass, overall lgtm.
it is great to see this happen, it can really simplify the UX for management cluster upgrades when using ClusterClass
43ee995
to
4a93fa6
Compare
4a93fa6
to
ab01bbe
Compare
ab01bbe
to
cdc2977
Compare
@fabriziopandini Should be ready for another round of review now. |
/assign @fabriziopandini |
@fabriziopandini PTAL. Findings should be addressed or answered |
bac1164
to
ec73efc
Compare
/test pull-cluster-api-e2e-full-main |
/lgtm @killianmuldoon PTAL |
ec73efc
to
38f07ef
Compare
Squashed the last fix |
/test pull-cluster-api-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thx for thr reviews! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Given this fixes / significantly improves the behavior during Cluster API upgrades I would like to cherry-pick this into the 1.2.x release /cherry-pick release-1.2 (cc @fabriziopandini ) |
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: #7231 failed to apply on top of branch "release-1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Manual cherry-pick > #7306 |
What this PR does / why we need it:
WIP => only first version, unit tests are not complete yet
Condition will be implemented in a separate PR.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #7212