Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 test/e2e: Add clusterctl upgrade with ClusterClass test #7244

Merged
merged 1 commit into from
Sep 29, 2022
Merged

🌱 test/e2e: Add clusterctl upgrade with ClusterClass test #7244

merged 1 commit into from
Sep 29, 2022

Conversation

sbueringer
Copy link
Member

@sbueringer sbueringer commented Sep 19, 2022 •
edited
Loading

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7226
Fixes #5704

Follow-up:

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2022
@sbueringer sbueringer mentioned this pull request Sep 19, 2022
Closed
@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch from 4fd2842 to 053f584 Compare September 19, 2022 17:41
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 19, 2022
@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch 2 times, most recently from 9272092 to 22db6f8 Compare September 19, 2022 18:10
@sbueringer sbueringer changed the title [WIP] 🌱 test/e2e: Add clusterctl upgrade with ClusterClass test 🌱 test/e2e: Add clusterctl upgrade with ClusterClass test Sep 19, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 19, 2022
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

To test the new test also in CI, it worked locally.

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch from 22db6f8 to bfc9280 Compare September 20, 2022 11:06
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch from bfc9280 to 081d8d2 Compare September 20, 2022 11:08
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch from 081d8d2 to 2aa49b8 Compare September 20, 2022 11:45
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch from 2aa49b8 to 897332e Compare September 20, 2022 11:46
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch 2 times, most recently from cbba2e7 to 41b4023 Compare September 20, 2022 12:49
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch 2 times, most recently from 98e5654 to c8eda34 Compare September 20, 2022 16:08
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch from 077c305 to 9313fda Compare September 23, 2022 05:23
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 23, 2022
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2022
@sbueringer
Copy link
Member Author

Tests looks stable now. Pushing the fixes for the review findings now. Might take 1-2 tries to get it green again (moved a lot of cluster templates)

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

Should be an unrelated flake

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

2 similar comments
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer force-pushed the pr-clusterctl-upgrade-clusterclass branch from ab24794 to 30faa69 Compare September 26, 2022 11:37
@sbueringer
Copy link
Member Author

Rebase onto latest main

/test pull-cluster-api-e2e-full-main

@sbueringer sbueringer changed the title [WIP] 🌱 test/e2e: Add clusterctl upgrade with ClusterClass test 🌱 test/e2e: Add clusterctl upgrade with ClusterClass test Sep 26, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 26, 2022
@sbueringer sbueringer mentioned this pull request Sep 26, 2022
Merged
@sbueringer
Copy link
Member Author

@fabriziopandini PTAL when you find some time. Thx :)

@sbueringer
Copy link
Member Author

Should be ready now

fabriziopandini
fabriziopandini reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit 69ab787 into kubernetes-sigs:main Sep 29, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Sep 29, 2022
@sbueringer sbueringer deleted the pr-clusterctl-upgrade-clusterclass branch September 29, 2022 13:31
@mboukhalfa mboukhalfa mentioned this pull request Sep 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@chrischdi chrischdi chrischdi left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
4 participants
@sbueringer @k8s-ci-robot @chrischdi @fabriziopandini