Correctly initialize klog in clusterctl #715
Conversation
Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
@neolit123 This was actually the behavior before, but I removed the flag by mistake in the 1.13 refresh. |
|
ok, in that case we should cancel the hold. |
k8s-ci-robot
removed
the
do-not-merge/hold
| - required: | ||
| - value | ||
| - required: | ||
| - valueFrom |
There was a problem hiding this comment.
This PR reverted a change previously made in #684
There was a problem hiding this comment.
I see, this is going to be replaced each time CRDs are regenereated given that kubebuilder doesn't support it.
There was a problem hiding this comment.
@detiber do you know any other ways to achieve this apart from a hacky kustomize / bash script?
There was a problem hiding this comment.
We probably need to create and track an issue against sigs.k8s.io/controller-runtime to get a proper fix in place.
…ostnames /etc/hosts update fixes cloudinit vmware reconcile
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: