[clusterctl] log to stdout by default #712
Conversation
Signed-off-by: Chuck Ha <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chuckha If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/M
| url = "https://github.com/bazelbuild/rules_go/releases/download/0.16.5/rules_go-0.16.5.tar.gz", | ||
| sha256 = "7be7dc01f1e0afdba6c8eb2b43d2fa01c743be1b9273ab1eaf6c233df078d705", | ||
| url = "https://github.com/bazelbuild/rules_go/releases/download/0.16.6/rules_go-0.16.6.tar.gz", | ||
| sha256 = "ade51a315fa17347e5c31201fdc55aa5ffb913377aa315dceb56ee9725e620ee", |
There was a problem hiding this comment.
The previous version of rules_go did not know about go 1.11.5 so make gazelle failed with "unknown go version 1.11.5"
| RootCmd.PersistentFlags().AddGoFlagSet(flag.CommandLine) | ||
| InitLogs() |
There was a problem hiding this comment.
InitLogs() no longer has callers. Is there a reason you did not change InitLogs() directly?
| @@ -50,6 +50,6 @@ func exitWithHelp(cmd *cobra.Command, err string) { | |||
|
|
|||
| func init() { | |||
| klog.InitFlags(flag.CommandLine) | |||
| klog.SetOutput(os.Stdout) | |||
|
@davidewatson @vincepri I don't think this is the right approach anymore. Deleting the logutils file seemed like a good idea at the time, but it turns out it was not. I'll need to dig deeper into this on Monday (unless someone gets to it first). |
|
@chuckha: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Remove vestigial scripts dir
Signed-off-by: Chuck Ha [email protected]
What this PR does / why we need it:
This PR sets
klogto log to stdout by default and removes the entirety of the logutil.go file.It also fixes the build since rules_go updated for go 1.11.5.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #711
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
/cc @vincepri