🐛 Add template flavor for topology-changes test

[killianmuldoon]

Signed-off-by: killianmuldoon [email protected]

Fix a failing e2e test caused by changes made in #7047 which overwrite the changes made in this test.

Add a new template to our e2e test package specifically for the broken test which patches the template to remove the overwriting value i.e. nodeDrainTimeout set in Cluster .spec.topology.controlPlane

/kind bug
/area testing

[k8s-ci-robot]

@killianmuldoon: This issue is currently awaiting triage.

If CAPI contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/test ?

[k8s-ci-robot]

@killianmuldoon: The following commands are available to trigger required jobs:

• /test pull-cluster-api-build-main
• /test pull-cluster-api-e2e-main
• /test pull-cluster-api-test-main
• /test pull-cluster-api-test-mink8s-main
• /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

• /test pull-cluster-api-apidiff-main
• /test pull-cluster-api-e2e-full-main
• /test pull-cluster-api-e2e-informing-ipv6-main
• /test pull-cluster-api-e2e-informing-main
• /test pull-cluster-api-e2e-workload-upgrade-1-21-1-22-main
• /test pull-cluster-api-e2e-workload-upgrade-1-24-latest-main

Use /test all to run the following jobs that were automatically triggered:

• pull-cluster-api-apidiff-main
• pull-cluster-api-build-main
• pull-cluster-api-e2e-informing-ipv6-main
• pull-cluster-api-e2e-informing-main
• pull-cluster-api-e2e-main
• pull-cluster-api-test-main
• pull-cluster-api-test-mink8s-main
• pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/test pull-cluster-api-e2e-main

[killianmuldoon]

/test pull-cluster-api-e2e-full-main

[chrischdi]

Would this break if #5880 gets done?

[killianmuldoon]

Would this break if #5880 gets done?

It's sort of unrelated as this test has to do with Cluster Class only and involves changing the drain timeout on the KCP template and seeing if it is propagated to the Control Plane object.

I think the impact of that change on the test depends a lot on implementation and we shouldn't worry about it until that happens.

[killianmuldoon]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@killianmuldoon: new pull request created: #7082

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.