-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to propagate properties in-place from MachineDeployments to Machines #5880
Comments
/milestone v1.1 |
/milestone v1.2 |
Note: there's now also a NodeDeletionTimeout which we should treat the same way. |
/retitle support to propagate properties in-place from MachineDeployments to Machines |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/lifecycle frozen |
/milestone Next |
/triage accepted |
moving out from the milestone because this will land later when also label propagation is fully addressed (hopefully in 1.4) |
@ykakarap Can you please double-check if this issue is now done with our recent implementations and close the issue if it makes sense. |
/unassign |
This issue is addressed in the in-place propagation work (#7731). The feature is merged and available. We can close this issue. /close |
@ykakarap: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
User Story
As a cluster operator I would like to change the NodeDrainTimeout/NodeDeletionTimeout for the Machines belonging to a MachineDeployment.
Detailed Description
Today this would trigger a rolling upgrade honouring current NodeDrainTimeout in Machines which defeats the purpose of the change. We should consider NodeDrainTimeout to propagate in-place from MachineDeployments to Machines.
Anything else you would like to add:
If we do this, base code should be scalable to have a clean way to include fields.
This might be relevant for #6255 as well
[Miscellaneous information that will assist in solving the issue.]
/kind feature
The text was updated successfully, but these errors were encountered: