Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to propagate properties in-place from MachineDeployments to Machines #5880

Closed
enxebre opened this issue Dec 21, 2021 · 13 comments
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@enxebre
Copy link
Member

enxebre commented Dec 21, 2021

User Story

As a cluster operator I would like to change the NodeDrainTimeout/NodeDeletionTimeout for the Machines belonging to a MachineDeployment.

Detailed Description

Today this would trigger a rolling upgrade honouring current NodeDrainTimeout in Machines which defeats the purpose of the change. We should consider NodeDrainTimeout to propagate in-place from MachineDeployments to Machines.

Anything else you would like to add:
If we do this, base code should be scalable to have a clean way to include fields.
This might be relevant for #6255 as well

[Miscellaneous information that will assist in solving the issue.]

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 21, 2021
@fabriziopandini
Copy link
Member

/milestone v1.1

@enxebre
Copy link
Member Author

enxebre commented Feb 3, 2022

/milestone v1.2

@k8s-ci-robot k8s-ci-robot modified the milestones: v1.1, v1.2 Feb 3, 2022
@sbueringer
Copy link
Member

Note: there's now also a NodeDeletionTimeout which we should treat the same way.

@enxebre
Copy link
Member Author

enxebre commented Mar 8, 2022

/retitle support to propagate properties in-place from MachineDeployments to Machines

@k8s-ci-robot k8s-ci-robot changed the title NodeDrainTimeout should propagate in-place from MachineDeployments to Machines support to propagate properties in-place from MachineDeployments to Machines Mar 8, 2022
@enxebre enxebre changed the title support to propagate properties in-place from MachineDeployments to Machines Support to propagate properties in-place from MachineDeployments to Machines Mar 8, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 6, 2022
@vincepri
Copy link
Member

vincepri commented Jun 7, 2022

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 7, 2022
@vincepri
Copy link
Member

vincepri commented Jun 7, 2022

/milestone Next

@fabriziopandini
Copy link
Member

/triage accepted
/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Oct 3, 2022
@fabriziopandini fabriziopandini added this to the v1.3 milestone Oct 3, 2022
@fabriziopandini fabriziopandini removed this from the v1.3 milestone Nov 2, 2022
@fabriziopandini
Copy link
Member

moving out from the milestone because this will land later when also label propagation is fully addressed (hopefully in 1.4)

@sbueringer
Copy link
Member

@ykakarap Can you please double-check if this issue is now done with our recent implementations and close the issue if it makes sense.

@fabriziopandini
Copy link
Member

/unassign
/assign @ykakarap

@ykakarap
Copy link
Contributor

ykakarap commented Mar 20, 2023

This issue is addressed in the in-place propagation work (#7731).

The feature is merged and available.

We can close this issue.

/close

@k8s-ci-robot
Copy link
Contributor

@ykakarap: Closing this issue.

In response to this:

This issue is addressed in the in-place propagation work (#7731).

The feature is merged and available.

We can close this isuse.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

7 participants