🐛 Fix nil pointer in patch Apply #7040
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
@killianmuldoon: This issue is currently awaiting triage. If CAPI contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/L
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
fix/nil-pointer-patch-option
branch
from
435439d to
ab93cc3
Compare
k8s-ci-robot
added
size/S
killianmuldoon
changed the title
| @@ -134,6 +134,9 @@ func (p Patch) Apply(latest Setter, options ...ApplyOption) error { | |||
|
|
|||
| applyOpt := &applyOptions{} | |||
| for _, o := range options { | |||
| if util.IsNil(o) { | |||
There was a problem hiding this comment.
There's a broader issue here about whether we should have nil checks for every arg to every public function for any type that can be nil.
These are the ones we uncovered because this is where the fuzzer touches, but I'm sure there's many more possible cases. I'll open an issue for this to get opinions.
The upside is it will be safer for consumers, but it's going to be messy in the code.
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: killianmuldoon [email protected]
Fix a nil pointer discovered through fuzzing. This condition is unlikely or impossible to occur in CAPI code, but is possible for consumers of the code.
Part of the broader issue discussed in #6334 (comment)