🐛 Add nil pointer check in UnstructuredUnmarshalField

[killianmuldoon]

Fix a nil pointer in the UnstructuredUnmarshalField function which gets thrown if the Object supplied is equal to nil.

Signed-off-by: killianmuldoon [email protected]

Fixes #6333

[killianmuldoon]

This should be backported I think - the original issue was spotted in 1.1.

[fabriziopandini]

@killianmuldoon just to link this with the issue, should we also clusterctl discovery to add nil nodes (this could also have strange effects on the UX)?

[killianmuldoon]

@fabriziopandini is the correct behaviour to display nil on the UX somehow? I'm not sure how this case is handled in clusterctl today. Should I try to approach it as part of this PR?

[vincepri]

/lgtm

[fabriziopandini]

@killianmuldoon do we still need this given that the root cause of thttps://github.com//issues/6333 seems to be condition missing (not the object being null)

[killianmuldoon]

I'd like to add this and create an issue to add similar checks to other public utils. I think these should never panic as we have no control over how they're consumed.

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment