✨ Add generic addon deployment config to tilt

[killianmuldoon]

Signed-off-by: killianmuldoon [email protected]

Add a generic deployment mechanism for addons to the tilt file and tilt prepare. This mechanism allows Runtime SDK extensions to be developed alongside the core controllers using the Tilt development flow. It can also be used to develop arbitrary deployments and addons built using the same workflow in tilt as providers use today.

May be related to #6647
/area runtime-sdk
Fixes #6864

[sbueringer]

Q: (possibly follow-up): I think Context here also has to be below a config element.

cf.:
vSphere:

{
  "name": "vsphere",
  "config": {
    "image": "gcr.io/cluster-api-provider-vsphere/release/manager",
    "live_reload_deps": [...],
    "label": "CAPV"
  }
}

Tiltfile:

    "core": {
        "context": ".",
        "image": "gcr.io/k8s-staging-cluster-api/cluster-api-controller",
        "live_reload_deps": [...],
        "label": "CAPI",
    }

Context seems to be on the same level as live_reload_deps and thus should be below config.

Just noticed when reviewing addonSettings.

[sbueringer]

We're getting very close. Mostly just nits/cleanup

[sbueringer]

I wonder if we should also allow arrays here like in the provider case to allow defining multiple addons per repository

Also totally up to you (or possibly follow-up PR)

[killianmuldoon]

I think we should leave that to a follow up if it's needed BTW - is there a provider that uses it this way today?

[sbueringer]

Afaik not. But I think for extensions/addons it makes sense to support more than one extension per repository.

I can take the follow-up, it's a relatively simple change. Making it relatively soon avoids that folks have to change their config later.

[sbueringer]

/lgtm
/approve

Looks great! We'll address the open findings in a follow-up PR.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[killianmuldoon]

/hold cancel

Wrong command at #6991 (comment) 🙂