-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add support for 'ipam' and 'other' providers to tilt #6647
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d12d374
to
537bb68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @fabriziopandini
Q: Is this the PR where we introduce new provider types by introducing Mostly asking because I'm not aware of that clusterctl or any other part of the code base supports it. (e.g. cluster-api/cmd/clusterctl/api/v1alpha3/labels.go Lines 45 to 56 in 477fd77
|
They are not supported by clusterctl. There is an issue regarding clusterctl support here: #6154 |
/hold As an alternative, we can merge this PR to simplify IPAM provider development, but we should clearly document in the comment/book that this is a temporary solution and it could lead to errors in the scenario described above |
I have no idea what changed, and I didn't even notice because I was working with this branch checked out locally for a while, but it seems like this change is no longer necessary. It used to cause errors to have a provider that's not recognised by tilt-prepare, but that error vanished. We probably don't need this anymore. default_registry: localhost:5000
allowed_contexts: ["kind-capi"]
kind_cluster_name: "capi"
provider_repos:
- ../cluster-api-ipam-provider-in-cluster
enable_providers:
# - docker
- ipam-in-cluster
extra_args:
core: ["--feature-gates=ClusterTopology=true"]
kubeadm-bootstrap: ["--feature-gates=ClusterTopology=true"]
kubeadm-control-plane: ["--feature-gates=ClusterTopology=true"]
docker: ["--feature-gates=ClusterTopology=true"]
debug:
ipam-in-cluster:
port: 30001 I'll reopen in case I run into issues again. |
What this PR does / why we need it:
This adds support for 'ipam-' and 'other-' providers to
tilt-prepare
to allow using ipam or any other new providers with our tilt setup.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):