-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 make TestControlPlaneTemplate deepcopy-able #6713
🌱 make TestControlPlaneTemplate deepcopy-able #6713
Conversation
Signed-off-by: killianmuldoon <[email protected]>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.2 |
@sbueringer: #6713 failed to apply on top of branch "release-1.2":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Let's skip the cherry-pick for now. I just hope we don't depend on it for other changes/tests we cherry-pick |
Diffed the branches anyway. So I think now it should work after another test change was cherry-picked /cherry-pick release-1.2 |
@sbueringer: new pull request created: #6750 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
Made the new TestControlPlaneTemplate deepcopy-able as discussed in #6700 (comment)
Part of #6016