Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Migrate more topology tests to Test* CRD #6700

Merged
merged 1 commit into from
Jun 22, 2022
Merged

🌱 Migrate more topology tests to Test* CRD #6700

merged 1 commit into from
Jun 22, 2022

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Migrate more topology tests to Test* CRD which are using a fully defined OpenAPI spec (vs using XPreserveUnknownFields); thus providing better signal now that we are using SSA

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2022
killianmuldoon
killianmuldoon reviewed Jun 22, 2022
View reviewed changes
internal/test/builder/infrastructure.go Show resolved Hide resolved
internal/test/builder/builders.go
}

// TestControlPlaneTemplate creates a NewControlPlaneTemplate builder with the given name and namespace.
func TestControlPlaneTemplate(namespace, name string) *TestControlPlaneTemplateBuilder {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be made deep-copyable? Like in #6016

I'd be happy to do this in a follow-up if you don't have time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fabriziopandini fabriziopandini force-pushed the migrate-more-test-to-test-CRDs branch from dfe3ba0 to 4daa06b Compare June 22, 2022 12:43
@sbueringer
Copy link
Member

sbueringer commented Jun 22, 2022 •
edited
Loading

/lgtm

+/- comment(s) from Killian + golangci-lint

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022
@fabriziopandini fabriziopandini force-pushed the migrate-more-test-to-test-CRDs branch from 4daa06b to c437cab Compare June 22, 2022 13:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022
@fabriziopandini fabriziopandini force-pushed the migrate-more-test-to-test-CRDs branch from c437cab to 78df6a6 Compare June 22, 2022 13:29
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 22, 2022
@fabriziopandini fabriziopandini force-pushed the migrate-more-test-to-test-CRDs branch from 78df6a6 to 1b75b10 Compare June 22, 2022 13:37
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 22, 2022
@sbueringer
Copy link
Member

/lgtm

@killianmuldoon fine for you as well?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2022
killianmuldoon
killianmuldoon reviewed Jun 22, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit fab808f into kubernetes-sigs:main Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jun 22, 2022
@killianmuldoon killianmuldoon mentioned this pull request Jun 23, 2022
Merged
@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jun 27, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #6748

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the migrate-more-test-to-test-CRDs branch July 5, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@fabriziopandini @sbueringer @k8s-ci-robot @k8s-infra-cherrypick-robot @killianmuldoon