Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][POC] ✨ Topology Mutation e2e #6577

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #6545

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 31, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from sbueringer after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 31, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch 6 times, most recently from e9a6cdc to 8abf66c Compare June 1, 2022 09:34
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from ebe96b1 to 8e7e209 Compare June 1, 2022 13:29
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 1, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from 8e7e209 to 1d2d1c0 Compare June 1, 2022 19:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from 1d2d1c0 to 083b6f7 Compare June 2, 2022 04:59
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 7, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from 083b6f7 to 1e4b0cd Compare June 9, 2022 17:56
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 9, 2022
@sbueringer sbueringer changed the title [WIP] ✨ Topology Mutation: Implement external patches [WIP][POC] ✨ Topology Mutation e2e Jun 10, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from c8de258 to 240c7c0 Compare June 10, 2022 12:57
@sbueringer sbueringer added the area/runtime-sdk Issues or PRs related to Runtime SDK label Jun 11, 2022
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from 898c958 to 4a4b102 Compare June 13, 2022 12:26
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from 283c13e to 7fbea31 Compare June 13, 2022 14:06
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch 2 times, most recently from 477d2f5 to f3bb25a Compare June 13, 2022 16:10
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 13, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch 3 times, most recently from 42305d7 to 5c8df7d Compare June 14, 2022 04:20
@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 5c8df7d link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2022
@sbueringer sbueringer force-pushed the pr-topology-mutation-external branch from 5c8df7d to 4a9e7ac Compare June 17, 2022 05:33
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 17, 2022
@sbueringer
Copy link
Member Author

Rebased to verify that we merged all changes. Only some poc docs left

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closed this PR.

In response to this:

Rebased to verify that we merged all changes. Only some poc docs left

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants