fixup

kubernetes-sigs · Jun 1, 2022 · 8abf66c · 8abf66c
1 parent 5f6adf4
commit 8abf66c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/config/crd/bases/runtime.cluster.x-k8s.io_extensionconfigs.yaml b/config/crd/bases/runtime.cluster.x-k8s.io_extensionconfigs.yaml
@@ -71,7 +71,7 @@ spec:
                         type: string
                       port:
                         description: Port is the port on the service that hosting
-                          ExtensionHandler. Default to 8443. `port` should be a valid
+                          ExtensionHandler. Default to 443. `port` should be a valid
                           port number (1-65535, inclusive).
                         format: int32
                         type: integer

diff --git a/exp/runtime/internal/controllers/extensionconfig_controller_test.go b/exp/runtime/internal/controllers/extensionconfig_controller_test.go
@@ -200,7 +200,7 @@ func TestExtensionReconciler_discoverExtensionConfig(t *testing.T) {
 
 		extensionConfig := fakeExtensionConfigForURL(ns.Name, extensionName, srv1.URL)
 
-		discoveredExtensionConfig, err := discoverExtensionConfig(ctx, runtimeClient, extensionConfig)
+		discoveredExtensionConfig, err := discoverExtensionConfig(ctx, nil, runtimeClient, extensionConfig)
 		g.Expect(err).To(BeNil())
 
 		// Expect exactly one handler and expect the name to be the handler name plus the extension name.
@@ -232,7 +232,7 @@ func TestExtensionReconciler_discoverExtensionConfig(t *testing.T) {
 
 		extensionConfig := fakeExtensionConfigForURL(ns.Name, extensionName, "http://localhost:31239")
 
-		discoveredExtensionConfig, err := discoverExtensionConfig(ctx, runtimeClient, extensionConfig)
+		discoveredExtensionConfig, err := discoverExtensionConfig(ctx, nil, runtimeClient, extensionConfig)
 		g.Expect(err).ToNot(BeNil())
 
 		// Expect exactly one handler and expect the name to be the handler name plus the extension name.

diff --git a/test/e2e/cluster_upgrade_runtimesdk_test.go b/test/e2e/cluster_upgrade_runtimesdk_test.go
@@ -148,7 +148,7 @@ func clusterUpgradeWithRuntimeSDKConformanceSpec(ctx context.Context, inputGette
 		clusterResources = new(clusterctl.ApplyClusterTemplateAndWaitResult)
 	})
 
-	It("Should create and upgrade a workload cluster and eventually run kubetest", func() {
+	It("Should create and upgrade a workload cluster", func() {
 		// FIXME(sbueringer): should we create an additional cluster and then deploy the extension there? (like self-hosted, ...)
 		By("Deploy Test Extension")
 		testExtensionDeployment, err := os.ReadFile(testExtensionPath) //nolint:gosec