Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Replace ⚠️ with ⚠️ in Contributing Guidelines documentation #6550

Merged
merged 2 commits into from
May 27, 2022
Merged

📖 Replace ⚠️ with ⚠️ in Contributing Guidelines documentation #6550

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c91625d
Replace :warning: with ⚠️ in Contributing Guidelines documentation
oscr May 25, 2022
872b668
Replace remaining :warning: tags
oscr May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ Help and contributions are very welcome in the form of code contributions but al

### Codebase and Go Modules

> :warning: The project does not follow Go Modules guidelines for compatibility requirements for 1.x semver releases.
> ⚠ The project does not follow Go Modules guidelines for compatibility requirements for 1.x semver releases.

Cluster API follows upstream Kubernetes semantic versioning. With the v1 release of our codebase, we guarantee the following:

Expand Down
2 changes: 1 addition & 1 deletion docs/book/src/developer/providers/v0.3-to-v0.4.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

- The KIND version used for this release is v0.11.x

## :warning: Go Module changes :warning:
## ⚠ Go Module changes ⚠

- The `test` folder now ships with its own Go module `sigs.k8s.io/cluster-api/test`.
- The module is going to be tagged and versioned as part of the release.
Expand Down
2 changes: 1 addition & 1 deletion docs/book/src/developer/providers/v0.4-to-v1.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ The `serving-cert` certificates now have organization set to `k8s-sig-cluster-li
controllers can use labels and annotations from template infrastructure resources to do external provisioning or
provide configuration information, e.g. [IPAM support for vSphere / bare-metal][capv-ipam].

## :warning: LeaderElectionResourceLock change :warning:
## ⚠ LeaderElectionResourceLock change ⚠

The v1beta1 release uses "leases" instead of "configmapsleases" as the LeaderElectionResourceLock for all managers leader election including the core controllers, bootstrap and control plane kubeadm and the Docker provider.
This has no user facing impact on brand-new clusters created as v1beta1.
Expand Down