-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Replace ⚠️ with ⚠️ in Contributing Guidelines documentation #6550
📖 Replace ⚠️ with ⚠️ in Contributing Guidelines documentation #6550
Conversation
Hi @oscr. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - the base issue here is that this is a dual use document.
We expect users to read it on github (where the warning is rendered correctly) and where it's mirrored in the book (and not rendered correctly).
I don't think it's a big issue - but there are a couple of other instances we could change. @oscr do you mind updating the other occurrences with the emoji instead of the tag?:
## :warning: Go Module changes :warning: |
## :warning: LeaderElectionResourceLock change :warning: |
/lgtm Awesome - thank you! |
Great catch! Thanks @killianmuldoon. I've fixed both. |
Thx! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Looks like⚠️ emoji. As a small side note: the commit message and diff preview look a little odd since Github seems to always render ⚠️ .
:warning:
isn't rendered in the Contributing Guidelines document (as shown below) so I suggest replacing it with the:warning:
ashttps://cluster-api.sigs.k8s.io/contributing#codebase-and-go-modules