Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add lifecycle hook types #6537

Conversation

killianmuldoon
Copy link
Contributor

Co-authored-by: ykakarap [email protected]
Signed-off-by: killianmuldoon [email protected]

Add types for the lifecycle hooks defined in the lifecycle hook proposal.

Part of #6330
Implements the types from proposal #5141

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 24, 2022
@killianmuldoon
Copy link
Contributor Author

killianmuldoon commented May 24, 2022

/hold

Until #5141 is merged

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 24, 2022
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an outstanding question in #6506
About whether we should compose the types by creating shared structs used throughout the top-level types.

I'm happy to do that in this PR if that's the direction we're looking to go.

@sbueringer
Copy link
Member

sbueringer commented May 25, 2022

There's an outstanding question in #6506 About whether we should compose the types by creating shared structs used throughout the top-level types.

I'm happy to do that in this PR if that's the direction we're looking to go.

As discussed yesterday, let's finalize #6506 and then depending on timing potentially update this PR to embed shared structs in the response types (alternatively we can do it in a follow-up PR).

Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise lgtm from my side

exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/hold cancel
#5141 has been merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@killianmuldoon
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2022
@killianmuldoon
Copy link
Contributor Author

Let's keep this on hold until #6499 is merged. There may be changes that I'd prefer to do once.

@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch from 115473c to bb8bb76 Compare May 31, 2022 12:53
@killianmuldoon
Copy link
Contributor Author

/hold cancel
This is unblocked by adding the CommonResponse type from #6499

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch 2 times, most recently from 9db0ba9 to dd3e6c8 Compare May 31, 2022 13:07
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch from dd3e6c8 to 94949a3 Compare May 31, 2022 14:34
@sbueringer
Copy link
Member

Thank you!
/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

Just a few minor nits. Not blocking.

exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/lifecyclehooks_types.go Outdated Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch from 94949a3 to 4a2f90e Compare May 31, 2022 22:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 31, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch 2 times, most recently from b299384 to 0773189 Compare June 1, 2022 10:57
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch from 0773189 to 5dd989f Compare June 1, 2022 11:06
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 1, 2022
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch from 5dd989f to 3149e35 Compare June 1, 2022 11:16
Co-authored-by: ykakarap <[email protected]>
Signed-off-by: killianmuldoon <[email protected]>
@killianmuldoon killianmuldoon force-pushed the runtimeSDK/lifecycle-hooks-types branch from 3149e35 to 62b6184 Compare June 1, 2022 11:22
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a question, optional though.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2022
@sbueringer
Copy link
Member

/lgtm

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types are consistent with what was discussed in the proposal, let's keep moving and eventually improve documentation as soon as we can audit the first set of generated OpenAPI specifications
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 10832d7 into kubernetes-sigs:main Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants