Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Implement Call and CallAll in RuntimeClient #6499

Merged
merged 1 commit into from
Jun 1, 2022
Merged

✨ Implement Call and CallAll in RuntimeClient #6499

merged 1 commit into from
Jun 1, 2022

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

Implements the Call and CallAll functions in the RuntimeClient. These functions are used to make the http calls to the Runtime Extension Handlers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #6330

/kind feature
/kind runtime-sdk

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 12, 2022
@k8s-ci-robot
Copy link
Contributor

@ykakarap: The label(s) kind/runtime-sdk cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

Implements the Call and CallAll functions in the RuntimeClient. These functions are used to make the http calls to the Runtime Extension Handlers.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #6330

/kind feature
/kind runtime-sdk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2022
@ykakarap
Copy link
Contributor Author

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added the area/runtime-sdk Issues or PRs related to Runtime SDK label May 12, 2022
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 12, 2022
@sbueringer sbueringer mentioned this pull request May 12, 2022
Closed
30 tasks
sbueringer
sbueringer reviewed May 12, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a high-level review, looks good overall

Just let me know when I should take a closer look

internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 13, 2022
@ykakarap ykakarap changed the title ✨ [WIP] Implement Call and CallAll in RuntimeClient ✨ [Implement Call and CallAll in RuntimeClient May 13, 2022
@ykakarap ykakarap changed the title ✨ [Implement Call and CallAll in RuntimeClient ✨ Implement Call and CallAll in RuntimeClient May 13, 2022
@ykakarap
Copy link
Contributor Author

@sbueringer I addressed the initial round of feedback. This is ready for a full review.

sbueringer
sbueringer reviewed May 13, 2022
View reviewed changes
exp/runtime/hooks/api/v1alpha1/aggregate.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/util.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/util.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/util.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/util_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request May 13, 2022
Closed
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 13, 2022
@ykakarap ykakarap force-pushed the runtime-sdk_client-results branch from 88b1787 to 7127493 Compare May 13, 2022 23:35
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 13, 2022
sbueringer
sbueringer reviewed May 24, 2022
View reviewed changes
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/catalog/test/catalog_test.go Show resolved Hide resolved
internal/runtime/catalog/catalog.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
sbueringer
sbueringer reviewed May 24, 2022
View reviewed changes
internal/runtime/client/client_test.go Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
internal/runtime/client/client_test.go Show resolved Hide resolved
internal/runtime/client/client_test.go Outdated Show resolved Hide resolved
@sbueringer sbueringer mentioned this pull request May 24, 2022
Closed
@killianmuldoon killianmuldoon mentioned this pull request May 25, 2022
Merged
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 27, 2022
killianmuldoon
killianmuldoon reviewed May 27, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also - I can't resolve conversations on this PR 😆

sbueringer
sbueringer reviewed May 27, 2022
View reviewed changes
exp/runtime/hooks/api/v1alpha1/common_types.go Outdated Show resolved Hide resolved
internal/runtime/catalog/test/catalog_test.go Outdated Show resolved Hide resolved
internal/runtime/test/v1alpha1/fake_types.go Outdated Show resolved Hide resolved
internal/runtime/test/v1alpha1/fake_types.go Show resolved Hide resolved
internal/runtime/test/v1alpha2/fake_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/discovery_types.go Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Also - I can't resolve conversations on this PR 😆

Just 👍 on the conversations you would resolve and I'll do it

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2022
fabriziopandini
fabriziopandini reviewed May 31, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits and questions.
Also, as soon as we are in a state where we can test all the pieces working together we should add some logging to call and callAll

exp/runtime/hooks/api/v1alpha1/common_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/common_types.go Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/common_types.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
@killianmuldoon killianmuldoon force-pushed the runtime-sdk_client-results branch 2 times, most recently from 66071b7 to e368018 Compare May 31, 2022 11:16
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 31, 2022
@killianmuldoon killianmuldoon force-pushed the runtime-sdk_client-results branch from 7c96685 to a38a206 Compare May 31, 2022 11:23
sbueringer
sbueringer reviewed May 31, 2022
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ last round of nits from my side

Makefile Outdated Show resolved Hide resolved
exp/runtime/hooks/api/v1alpha1/common_types.go Outdated Show resolved Hide resolved
internal/runtime/test/v1alpha1/fake_types.go Outdated Show resolved Hide resolved
internal/runtime/test/v1alpha1/fake_types.go Outdated Show resolved Hide resolved
internal/runtime/test/v1alpha2/fake_types.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed May 31, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
sbueringer
sbueringer reviewed May 31, 2022
View reviewed changes
internal/runtime/client/client.go Outdated Show resolved Hide resolved
internal/runtime/client/client.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

sbueringer commented May 31, 2022 •
edited
Loading

🎉 Thank you very much

lgtm pending squash from my side!

@killianmuldoon killianmuldoon force-pushed the runtime-sdk_client-results branch from 518a919 to 32274b3 Compare May 31, 2022 16:29
@k8s-ci-robot
Copy link
Contributor

@ykakarap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-apidiff-main 32274b3 link false /test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

Thank you very much.

Nice work @killianmuldoon @ykakarap !!

/assign @fabriziopandini

fabriziopandini
fabriziopandini reviewed Jun 1, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2022
@k8s-ci-robot k8s-ci-robot merged commit 1c8b76d into kubernetes-sigs:main Jun 1, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@ykakarap @k8s-ci-robot @sbueringer @chrischdi @fabriziopandini @killianmuldoon