-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Upgrade to controller-runtime v0.12.2 and k8s.io/* v0.24.* #6467
Conversation
c72e731
to
c2d3bd2
Compare
internal/topology/variables/clusterclass_variable_validation.go
Outdated
Show resolved
Hide resolved
Thx, looks good overall one nit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that Kubernetes 1.24 is released maybe we should wait for a controller runtime release incorporating the new K8s version ?
@killianmuldoon -- A PR is open to update the same in CR: kubernetes-sigs/controller-runtime#1885 I agree we can wait for that land. |
CR master now has Kubernetes 1.24 packages. I have updated the PR. Note: I will squash the commits and organize them into 2 or 3 based on functionality after another round of review. |
/retitle 🌱 Upgrade controller-runtime to latest master for bringing in Kubernetes 1.24.0 changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a big-ish API diff because of the deprecation of ClusterName in metadata. I think we can safely ignore that as the fielld wasn't (correctly) used at any point.
@palnabarun Could you maybe add a not to the migration guide (https://main.cluster-api.sigs.k8s.io/developer/providers/v1.1-to-v1.2.html) with a short note about the ClusterName deprecation?
@palnabarun lgtm from my side +/- squash and the note Killian mentioned would be good (mentioning the upgraded dependencies (like for the previous release) + a short note that ClusterName has been removed would be good) |
@palnabarun just fyi. controller-runtime v0.12 was just released. If you don't mind, we could directly upgrade to the release. |
e3d00ea
to
1c3914b
Compare
@palnabarun Do you have time to follow-up on this PR? |
@palnabarun Looks good. |
@sbueringer -- Hey, sorry for not following up on this earlier. I was travelling/out of the office most of the last month. I have updated the docs. I think the |
43c7fcf
to
6f42356
Compare
Squashed changes to a single commit. |
Thx! /lgtm |
/retest |
/retest |
pull-cluster-api-e2e-workload-upgrade-1-24-latest-main is expected (also fails on main) /test pull-cluster-api-e2e-full-main |
- refactor code wherever needed - recreate generated files - book: document dependency updates and field removals Signed-off-by: Nabarun Pal <[email protected]>
6f42356
to
1167c97
Compare
@palnabarun: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@palnabarun Thank you very much! |
xref #5968 |
What this PR does / why we need it:
The latest tag of controller-runtime is https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.12.1
Also, bumps the same for hack/tools and test.
Which issue(s) this PR fixes:
None
/assign @sbueringer