✨ introduce runtime-openapi-gen to generate openapi spec on release #6462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
reviewed
Apr 29, 2022
sbueringer
reviewed
Apr 29, 2022
chrischdi
force-pushed
the
pr-runtime-sdk-runtime-openapi-gen
branch
from
d6a0865 to
7dfbfec
Compare
|
No rush, but just fyi, the latest push --force didn't seem to push everything (just in case you already did implement it :) ) |
sbueringer
reviewed
Apr 29, 2022
chrischdi
force-pushed
the
pr-runtime-sdk-runtime-openapi-gen
branch
6 times, most recently
from
33fd791 to
9bbd3cf
Compare
|
/area runtime-sdk |
k8s-ci-robot
added
area/runtime-sdk
30 tasks
sbueringer
reviewed
May 11, 2022
chrischdi
force-pushed
the
pr-runtime-sdk-runtime-openapi-gen
branch
from
9bbd3cf to
18154e6
Compare
k8s-ci-robot
removed
the
needs-rebase
* openapi-gen: modified upstream openapi-gen to generate zz_generated.openapi.go files * runtime-openapi-gen consumes runtime SDK catalog and generated openapi spec to generate openapi yaml spec Co-authored-by: Stefan Bueringer <[email protected]> Co-authored-by: Christian Schlotter <[email protected]>
chrischdi
force-pushed
the
pr-runtime-sdk-runtime-openapi-gen
branch
from
18154e6 to
2344b28
Compare
|
/retest |
chrischdi
changed the title
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
killianmuldoon
approved these changes
May 12, 2022
|
@chrischdi great work! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces adds the upstream
openapi-gento generate go openapi definitions andruntime-openapi-gento generate a openapi spec for Runtime SDK hooks on release.Requires #6455 to get merged first.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #6330
TODOs: