✨ Move machinepool and CRS feature gate checks to webhooks #6348
Conversation
k8s-ci-robot
added
cncf-cla: yes
There was a problem hiding this comment.
Thanks for this @Karthik-K-N! I think you've uncovered some issues with our linters with this change too 🙂 I've put in the ways to fix the imports below in suggestions.
| ) | ||
|
|
||
| func TestMachinePoolConversion(t *testing.T) { | ||
| // NOTE: MachinePool feature flag is disabled by default, thus preventing to create or update MachinePool. |
There was a problem hiding this comment.
Note: I think it's fine to add this as part of this PR, but we should open an issue to update how the conversion tests/webhook in the MachinePool is done. I'm not sure what our testing area is exactly if we have this test in v1alpha3, but nothing in v1alpha4.
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR contains the changes to move the feature gate checks for Machinepool and CRS from main.go file to respective webhooks, This helps in better display of error messages for users incase they are trying to create resources without enabling the feature flags.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #6331