Enable feature flag disabled error reporting for MachinePool, ClusterResourceSet #6331
Labels
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone
User Story
As a user I would like to get transparent errors about Feature Flags on object creation.
Detailed Description
In order to get clear errors about feature flag status we can enable webhooks for objects when the associated feature flag is not enabled. The issue with this is whether or not enabling the webhooks in this way violates the way users understand feature flags.
All we're enabling here is reporting the status of the feature flag using the webhook so IMO this should not be a problem.
Additional Details
Currently there are two patterns in Cluster API for dealing with webhooks and feature flags:
Pattern 1: Don't start the webhook
MachinePools, ClusterResourceSet
Error:
Pattern 2: Start the webhook but refuse object creation and updates.
Error:
Steps to implement
Both patterns block usage of the feature, but the error message from pattern 2 is readable and tells users exactly what happened. As a user I would prefer to see this error so I understand what changes I make to the system.
To do this we would need to:
/kind feature
The text was updated successfully, but these errors were encountered: