Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 [e2e] Checks unexpected rollouts during clusterctl upgrade #6184

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Feb 21, 2022

What this PR does / why we need it:

Check for unexpected rollouts in the clusterctl upgrade e2e test.

TODO:

  • Run this against the v1.1.0 version of Cluster API code to check if the test captures the unexpected rollout.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2022
@ykakarap
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2022
@sbueringer
Copy link
Member

sbueringer commented Feb 22, 2022

@ykakarap I think you could also temporarily add a revert-commit to this branch to test if the test would detect the issue

test/e2e/clusterctl_upgrade.go Show resolved Hide resolved
test/e2e/clusterctl_upgrade.go Outdated Show resolved Hide resolved
test/e2e/clusterctl_upgrade.go Outdated Show resolved Hide resolved
@ykakarap
Copy link
Contributor Author

@ykakarap I think you could also temporarily add a revert-commit to this branch to test if the test would detect the issue

I have a branch with this commit 6ae0a73 dropped. Will be testing it against this test branch.

@ykakarap ykakarap changed the title 🌱 [WIP] [e2e] Checks unexpected rollouts during clusterctl upgrade 🌱 [e2e] Checks unexpected rollouts during clusterctl upgrade Feb 22, 2022
@ykakarap
Copy link
Contributor Author

I have a branch with this commit 6ae0a73 dropped. Will be testing it against this test branch.

Tested it against this version of code (causes kcp rollout on clusterctl upgrade). The test captures the rollout and fail as expected. Dropping WIP.

test/e2e/config/docker.yaml Outdated Show resolved Hide resolved
test/e2e/clusterctl_upgrade.go Show resolved Hide resolved
@ykakarap ykakarap force-pushed the e2e-detect-rollout branch from 16a61b6 to 2a84de8 Compare March 7, 2022 11:32
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-main

@sbueringer
Copy link
Member

lgtm from my side

@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2022
@sbueringer
Copy link
Member

/lgtm
/approve

@fabriziopandini
Copy link
Member

@ykakarap can we remove the hold?

@ykakarap
Copy link
Contributor Author

ykakarap commented Mar 8, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 2466594 into kubernetes-sigs:main Mar 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants