-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [e2e] Checks unexpected rollouts during clusterctl upgrade #6184
Conversation
/hold |
@ykakarap I think you could also temporarily add a revert-commit to this branch to test if the test would detect the issue |
84d560a
to
8824f9b
Compare
Tested it against this version of code (causes kcp rollout on clusterctl upgrade). The test captures the rollout and fail as expected. Dropping WIP. |
8824f9b
to
16a61b6
Compare
16a61b6
to
2a84de8
Compare
/test pull-cluster-api-e2e-main |
lgtm from my side |
/lgtm |
/lgtm |
@ykakarap can we remove the hold? |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Check for unexpected rollouts in the clusterctl upgrade e2e test.
TODO:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #