Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterctl upgrade e2e tests should detect if upgrade causes unexpected rollouts #6094

Closed
ykakarap opened this issue Feb 10, 2022 · 8 comments · Fixed by #6926
Closed

clusterctl upgrade e2e tests should detect if upgrade causes unexpected rollouts #6094

ykakarap opened this issue Feb 10, 2022 · 8 comments · Fixed by #6926
Assignees
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@ykakarap
Copy link
Contributor

ykakarap commented Feb 10, 2022

User Story

The clusterctl upgrade e2e tests currently do not detect if an upgrade operation results in rollout of KCP, MachineDeployments, etc.

Having such a test could help in detecting cases like #6093.

Detailed Description

[A clear and concise description of what you want to happen.]

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 10, 2022
@ykakarap
Copy link
Contributor Author

/assign

@ykakarap
Copy link
Contributor Author

ykakarap commented Feb 10, 2022

We might benefit for doing similar checks in the clusterctl move e2e tests too.

@sbueringer
Copy link
Member

sbueringer commented Feb 10, 2022

+1 I assume you mean extending the existing clusterctl upgrade test
+1 to doing the same for the self hosted test (which uses clusterctl move)

@vincepri
Copy link
Member

/milestone v1.2
/priority important-soon
/area testing

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Feb 11, 2022
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/testing Issues or PRs related to testing labels Feb 11, 2022
@sbueringer
Copy link
Member

sbueringer commented May 12, 2022

This has been implemented for the clusterctl upgrade test: #6184
So I think only doing the same for the self-hosted test is left.

@ykakarap
Copy link
Contributor Author

This has been implemented for the clusterctl upgrade test: #6184 So I think only doing the same for the self-hosted test is left.

Issue for adding rollout check to self hosted e2e tests: #6925

@sbueringer
Copy link
Member

Okay. I'll close this issue given we have a separate one for self-hosted

/close

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

Okay. I'll close this issue given we have a separate one for self-hosted

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants