Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Validate OWNERS files - remove sections about emeritus reviewers. #5964

Merged
merged 1 commit into from
Jan 24, 2022
Merged

🌱 Validate OWNERS files - remove sections about emeritus reviewers. #5964

merged 1 commit into from
Jan 24, 2022

Conversation

peizhouyu
Copy link
Contributor

@peizhouyu peizhouyu commented Jan 21, 2022 •
edited
Loading

please see kubernetes/community#6334

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @peizhouyu!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 21, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @peizhouyu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 21, 2022
fabriziopandini
fabriziopandini reviewed Jan 21, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2022
@fabriziopandini fabriziopandini changed the title Validate OWNERS files - remove sections about emeritus reviewers. 🌱 Validate OWNERS files - remove sections about emeritus reviewers. Jan 21, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2022
@killianmuldoon
Copy link
Contributor

/lgtm

Just wondering why the signoff in the PR description is:

Signed-off-by: Davanum Srinivas [email protected]

I don't think it matters - is it just copy-paste?

@sbueringer
Copy link
Member

/lgtm

Just wondering why the signoff in the PR description is:

Signed-off-by: Davanum Srinivas [email protected]

I don't think it matters - is it just copy-paste?

@peizhouyu Can you please remove it from the PR description? Thank you :)

@peizhouyu
Copy link
Contributor Author

/lgtm

Just wondering why the signoff in the PR description is:

Signed-off-by: Davanum Srinivas [email protected]

I don't think it matters - is it just copy-paste?

@peizhouyu Can you please remove it from the PR description? Thank you :)
Thanks for spotting the problem, I't was removed.
Thank you

mkumatag
mkumatag suggested changes Jan 24, 2022
View reviewed changes
OWNERS Outdated
emeritus_maintainers:
- detiber
- ncdc
- davidewatson
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline here in the end

Copy link
Contributor Author

@peizhouyu peizhouyu Jan 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a newline here in the end

I've already added it，Thanks.

@peizhouyu peizhouyu force-pushed the peizhouyu_Validate_OWNERS_files_-_remove_sections_about_emeritus_reviewers branch from 42c1da5 to f6a52f1 Compare January 24, 2022 07:01
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2022
mkumatag
mkumatag reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2022
@sbueringer
Copy link
Member

/lgtm

fabriziopandini
fabriziopandini reviewed Jan 24, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@k8s-ci-robot k8s-ci-robot merged commit 0d0d0c9 into kubernetes-sigs:main Jan 24, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1 milestone Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag requested changes

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@mkumatag mkumatag

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
6 participants
@peizhouyu @k8s-ci-robot @fabriziopandini @killianmuldoon @sbueringer @mkumatag