Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup emeritus_reviewers and emeritus_maintainers from OWNERS files across kubernetes orgs #6334

Closed
dims opened this issue Jan 12, 2022 · 39 comments
Closed

cleanup emeritus_reviewers and emeritus_maintainers from OWNERS files across kubernetes orgs #6334

dims opened this issue Jan 12, 2022 · 39 comments
Assignees
@ElvertMora @peizhouyu @Garima-Negi @keviny11 @sreekaransrinath @rajatgupta24 @ShaileshKumar007
Labels
area/community-management good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@dims
Copy link
Member

dims commented Jan 12, 2022 •
edited
Loading

Describe the issue

Following up from #6333 (comment) and #6333 (comment)

We need to cleanup https://cs.k8s.io/?q=emeritus_reviewers&i=nope&files=OWNERS*&excludeFiles=&repos= and https://cs.k8s.io/?q=emeritus_maintainers&i=nope&files=OWNERS*&excludeFiles=&repos= looks like we need to clean them all up

Original discussion in #3627 (comment)

Also see https://github.com/kubernetes/community/blob/master/contributors/guide/owners.md#owners for the list of official fields

Why are we solving this issue?

  • We need the OWNERS file to have the correct structure so it is parsable by tools

To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?

  • Yes, click on the url(s), checkout the repositories which have emeritus_reviewers or emeritus_maintainers in their OWNERS files, submit a patch that removes these sections

Does this issue have zero to low barrier of entry?

  • Yes.

How can the assignee reach out to you for help?

  • Yes. on sig-contribex
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jan 12, 2022
@dims
Copy link
Member Author

dims commented Jan 12, 2022

cc @mrbobbytables

@dims
Copy link
Member Author

dims commented Jan 12, 2022

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 12, 2022
@dims dims mentioned this issue Jan 12, 2022
Merged
@dims
Copy link
Member Author

dims commented Jan 12, 2022

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@dims:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 12, 2022
@Garima-Negi
Copy link

/assign

@dims
Copy link
Member Author

dims commented Jan 12, 2022 •
edited
Loading

@Garima-Negi found more problematic repositories / files:

https://cs.k8s.io/?q=%5E(emeritus%7Cemeritus-approvers%7Cemeritus_approver%7Cemeritus_maintainers%7Cemeritus_reviewer%7Cemeritus_reviewers%7Cowners)%3A&i=nope&files=OWNERS*&excludeFiles=&repos=

@dims
Copy link
Member Author

dims commented Jan 12, 2022 •
edited
Loading

So the idea here is to open a PR in each repository to remove the section with the wrong key namely:

emeritus
emeritus-approvers
emeritus_approver
emeritus_maintainers
emeritus_reviewer
emeritus_reviewers
owners

When the reviewers ask we point them to this issue and say that the allowed keys are one of those mentioned here:
https://github.com/kubernetes/test-infra/blob/eb87a9362476e00852ac398a2b6417d1f01d4b48/prow/repoowners/repoowners.go#L57-L60

or emeritus_approvers (per conversation in #3627 (comment))

ping me on slack or here if there are any push backs.

Also if someone else can help you, please carve out which repositories you each will tackle as there are a bunch of them.

@dims
Copy link
Member Author

dims commented Jan 12, 2022

Oh! sorry if you see emeritus-approvers or emeritus_approver you can change it to emeritus_approvers anything else you can delete and follow what the reviewers guidance if they would like the names in another section.

This was referenced Jan 13, 2022
Merged
Merged
@dims
Copy link
Member Author

dims commented Jan 13, 2022

@Garima-Negi i've updated search url in #6334 (comment) and opened 2 PR(s) for kubernetes/kubernetes and kubernetes/test-infra to unblock some other stuff i am doing.

dims added a commit to dims/csi-release-tools that referenced this issue Jan 13, 2022
@dims
Validate OWNERS file
dc60c84 
- supported section name is `emeritus_approvers` (so add a `s`)
- there isn't a supported section for emeritus reviewers (so remove the entire section)

please see https://go.k8s.io/owners for additional info and kubernetes/community#6334 with a bunch of other cleanups we are doing.
@dims dims mentioned this issue Jan 13, 2022
Closed
@peizhouyu
Copy link

/assign

@peizhouyu peizhouyu mentioned this issue Jan 17, 2022
Closed
@peizhouyu
Copy link

/assign

hi, @dims @Garima-Negi i've updated kubernetes-csi/csi-test, other things about kubernetes-csi I'm doing. Thanks.

@Garima-Negi
Copy link

@dims what do we update emeritus-maintainers to ?

@dims
Copy link
Member Author

dims commented Jan 17, 2022 •
edited
Loading

@dims what do we update emeritus-maintainers to ?

@Garima-Negi yes please.

@sreekaransrinath
Copy link
Contributor

/assign

This was referenced Jan 18, 2022
Closed
Merged
@Garima-Negi
Copy link

@dims looks like we are only waiting on [kubernetes-csi/csi-release-tools#185](Fix OWNERS files with allowed keywords kubernetes-csi/csi-release-tools#185) for this issue to be solved.

I'[ll be squashing the commits and see if that moves it forward quickly.

@dims
Copy link
Member Author

dims commented Feb 2, 2022

thanks @Garima-Negi

@pohly
Copy link
Contributor

pohly commented Feb 3, 2022

@Garima-Negi we are waiting for you to addresss kubernetes-csi/csi-release-tools#185 (comment)...

@rajatgupta24 rajatgupta24 mentioned this issue Feb 3, 2022
Merged
@Garima-Negi
Copy link

@pohly just pushed a commit to squash. Should be merged soon! Sorry for the delay

@Garima-Negi
Copy link

kubernetes-csi/csi-release-tools#183 is the remaining open PR on this issue. But kubernetes-csi/csi-release-tools#185 has been merged already (these 2 PRs are duplicates)
We can close the open PR.

@dims
Copy link
Member Author

dims commented Feb 9, 2022

thanks for all your work on this @Garima-Negi !!

This was referenced Feb 17, 2022
Closed
Closed
Closed
@AnteBox AnteBox mentioned this issue Feb 25, 2022
Closed
@keviny11
Copy link

/assign

@AnteBox AnteBox mentioned this issue Feb 28, 2022
Closed
@rohit777anand
Copy link

@k8s-ci-robot /assign

@ShaileshKumar007
Copy link

/assign

This was referenced Mar 10, 2022
Closed
Merged
Merged
@AndreSPy1
Copy link

AndreSPy1 commented Mar 14, 2022 •
edited
Loading

@dims Hello, do we have to change "emeritus_reviewers" to Reviewers?

@AndreSPy1
Copy link

/assign

@jakspok
Copy link

jakspok commented Mar 14, 2022 •
edited
Loading

/assign

1 similar comment
@ElvertMora
Copy link

/assign

@Brijesh-09
Copy link

I want to work on this issue can you assign it to me?

@AndreSPy1 AndreSPy1 removed their assignment Apr 18, 2022
@dims
Copy link
Member Author

dims commented May 1, 2022

I think we have done a bunch of this. Closing this for now, we may do this again.

@dims dims closed this as completed May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElvertMora ElvertMora

@peizhouyu peizhouyu

@Garima-Negi Garima-Negi

@keviny11 keviny11

@sreekaransrinath sreekaransrinath

@rajatgupta24 rajatgupta24

@ShaileshKumar007 ShaileshKumar007

Labels
area/community-management good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove emeritus_reviewers from OWNERS file srinivas-pokala/blob-csi-driver