🌱 Use ClusterClass name index in ClusterClass webhook #5810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XL
killianmuldoon
changed the title
k8s-ci-robot
added
the
needs-rebase
killianmuldoon
force-pushed
the
webhook/cluster-index
branch
from
e9d2031 to
cdcefbd
Compare
k8s-ci-robot
removed
the
needs-rebase
killianmuldoon
changed the title
killianmuldoon
changed the title
killianmuldoon
commented
Feb 7, 2022
| }, | ||
| { | ||
| name: "error if many MachineDeploymentClasses, used in multiple Clusters using the modified ClusterClass, are removed", |
There was a problem hiding this comment.
Tests removed here as they no longer work after the move to using the index. Index requires envtest and these tests rely solely on fakeclient.
killianmuldoon
changed the title
sbueringer
reviewed
Feb 8, 2022
killianmuldoon
force-pushed
the
webhook/cluster-index
branch
2 times, most recently
from
d94cd51 to
4066f8a
Compare
k8s-ci-robot
added
size/L
|
@killianmuldoon thx! lgtm pending squash |
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
webhook/cluster-index
branch
from
4066f8a to
7726885
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon [email protected]
Add the ClusterClass name index to the client call for getting a ClusterClass in the ClusterClass webhook.
Certain tests are moved to a new subpackage in order to run them with envtest. This is required as the fakeclient doesn't set up the indexes now in use by the ClusterClass webhook.
Note this PR includes duplicate files from #5803 and should not be merged until that PR is completed.
Fixes #5719