🌱 add basic integration tests for ClusterClass webhook

[killianmuldoon]

Signed-off-by: killianmuldoon [email protected]

This PR adds basic integration tests for the ClusterClass webhook assessing whether Create, Delete and Update validations work as expected with a real API server.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ killianmuldoon (08a5051)

[killianmuldoon]

Question: In order to add the index check to the ClusterClass webhooks client.Get (clusters) #5719 We'd need to port many complex table tests to use envtest in this package. Is that the direction I should go?

/cc @fabriziopandini @sbueringer

[sbueringer]

Question: In order to add the index check to the ClusterClass webhooks client.Get (clusters) #5719 We'd need to port many complex table tests to use envtest in this package. Is that the direction I should go?

/cc @fabriziopandini @sbueringer

I'm not sure I get the full context. But I would assume it's good enough to cover the case where we also have another cluster which is not using the same ClusterClass. I think everything else doesn't have to duplicated.

[killianmuldoon]

@sbueringer I think there's three cases that currently require testenv and I'll probably add in a couple more. The plan is to add the indexer and the testenv dependent test cases to this directory (In another PR) - does that sound right to you?

[sbueringer]

@sbueringer I think there's three cases that currently require testenv and I'll probably add in a couple more. The plan is to add the indexer and the testenv dependent test cases to this directory (In another PR) - does that sound right to you?

Sounds good to me.

[killianmuldoon]

/check-cla

[sbueringer]

Thx! lgtm pending squash

[sbueringer]

/lgtm

[fabriziopandini]

Should this be

Suggested change

	g.Expect(env.Create(ctx, clusterClass)).To(Succeed())
	g.Expect(env.CreateAndWait(ctx, clusterClass)).To(Succeed())

so we reduce the chance of flakiness (same below when we have objects depending on each others)

[killianmuldoon]

Good idea - I've also changed the Deletes to Cleanups / CleanupAndWait where appropriate.

[fabriziopandini]

yay! more tests!
/lgtm

[sbueringer]

Thx!
/lgtm

[fabriziopandini]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment