🌱 Tiltfile: Enable debugging with delve

[randomvariable]

Signed-off-by: Naadir Jeewa [email protected]

What this PR does / why we need it:

After chatting with @sbueringer , been thinking of ways of making using debuggers easier.
This enables adding the following in tilt-settings.json, for example, to enable a remote debugger to be attached to the core controller on 127.0.0.1:30000 when using Tilt:

  "debug": {
    "core": {
      "race_detector": true,
      "port": 30000,
      "profiler_port": 40000,
      "metrics_port": 40001
    },
    "kubeadm-bootstrap": {
      "port": 30001
    },
    "kubeadm-control-plane": {
      "port": 30002
    },
    "docker": {
      "port": 30003
    },
    "aws": {
      "port": 30004
    }
  },

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[fabriziopandini]

That will be super useful! Thanks for driving this!

[randomvariable]

/hold

Would like someone on MacOS to test. This works on Linux, but on MacOS we have the complexity of Docker Machine. However, given that this is using port forwarding via the API server, it shouldn't require additional networking hacks.

[sbueringer]

/hold

Would like someone on MacOS to test. This works on Linux, but on MacOS we have the complexity of Docker Machine. However, given that this is using port forwarding via the API server, it shouldn't require additional networking hacks.

I'll test it

[sbueringer]

@randomvariable Looks great and works on MacOS, thx!!

A few comments, mostly nits, but imho it would be great to default to using dlv with --continue.

[randomvariable]

/unhold

Have addressed the comments.

[fabriziopandini]

lgtm pending one question about go version bump

[fabriziopandini]

/lgtm
over to @vincepri @CecileRobertMichon (mostly because we add yq to our toolset, but this seems straight forward IMO)

[sbueringer]

Very nice!
/lgtm

[randomvariable]

over to @vincepri @CecileRobertMichon (mostly because we add yq to our toolset, but this seems straight forward IMO)

I'm intending (in another PR) to extend the usage of yq to get rid of editing manifests in place whenever we do e2es as well.

[vincepri]

/approve
/lgtm

Thank you @randomvariable, this is great!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mboersma]

Since this if line was removed, I get this stack trace when running tilt up:

local: ./hack/tools/bin/kustomize build ../cluster-api-provider-azure/config/default | ./hack/tools/bin/envsubst 
Traceback (most recent call last):
  /Users/matt/projects/cluster-api/Tiltfile:342:17: in <toplevel>
  /Users/matt/projects/cluster-api/Tiltfile:309:24: in enable_providers
  /Users/matt/projects/cluster-api/Tiltfile:288:21: in enable_provider
  <builtin>: in k8s_resource
Error: k8s_resource: for parameter "workload": Value should be convertible to string, but is type NoneType

My debugging configuration was happy before, and it's happy when I restore that line. Should I make a PR to restore the if check?