Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fields to tilt-provider.json #1796

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Add missing fields to tilt-provider.json #1796

merged 1 commit into from
Oct 26, 2021

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Oct 26, 2021 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Adds some missing fields to tilt-provider.json that were effectively ignorable before kubernetes-sigs/cluster-api#5485 merged. Copied from AWS' version.

Which issue(s) this PR fixes:

Refs kubernetes-sigs/cluster-api#5505

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 26, 2021
CecileRobertMichon
CecileRobertMichon reviewed Oct 26, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2021
@CecileRobertMichon
Copy link
Contributor

tested locally

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2021
@mboersma
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1210ada into kubernetes-sigs:main Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.5 milestone Oct 26, 2021
@mboersma mboersma deleted the update-tilt-provider branch October 27, 2021 15:57
@CecileRobertMichon CecileRobertMichon modified the milestones: v0.5, v1.0 Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@devigned devigned Awaiting requested review from devigned

@nader-ziada nader-ziada Awaiting requested review from nader-ziada

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mboersma @CecileRobertMichon @k8s-ci-robot