📖 Add clusterclass quickstart guide #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
|
New version fixes most of the nits, errors and issues. Outstanding are things that rely on v1beta1/1.0 - machineDeployment columns and v1beta1 types. I haven't been able to prove this out with clusterctl just yet, but can update as soon as I'm sure. |
|
Updated now to v1beta1 types using the release candidate version of CAPI and other providers. |
| - Install [Kind] and [Docker] | ||
|
|
||
| ClusterClass is currently behind a feature gate that needs to be enabled. | ||
| This tutorial will also use another experimental gated feature - Cluster Resource Set - in this tutorial. This is not required for ClusterClass but is used in this tutorial to set up networking. |
There was a problem hiding this comment.
Suggested change
| This tutorial will also use another experimental gated feature - Cluster Resource Set - in this tutorial. This is not required for ClusterClass but is used in this tutorial to set up networking. | |
| This tutorial will also use another experimental gated feature - Cluster Resource Set -. This is not required for ClusterClass to work, but is used in this tutorial to set up networking. |
There was a problem hiding this comment.
Suggested change
| This tutorial will also use another experimental gated feature - Cluster Resource Set - in this tutorial. This is not required for ClusterClass but is used in this tutorial to set up networking. | |
| This tutorial will also use another experimental gated feature - Cluster Resource Set -. This is not required for ClusterClass but is used in this tutorial to set up networking. |
| 1) KubeadmConfigTemplate | ||
|
|
||
| The ClusterClass - first in the below yaml - contains references to the templates needed to build a full cluster using the shape defined in the ClusterClass. | ||
| ```yaml |
There was a problem hiding this comment.
I'm ok with both solutions. Up to you
vincepri
reviewed
Oct 4, 2021
k8s-ci-robot
added
size/XL
sbueringer
reviewed
Oct 4, 2021
sbueringer
reviewed
Oct 4, 2021
test/infrastructure/docker/examples/clusterclass-quickstart.yaml
Outdated
Show resolved
Hide resolved
sbueringer
reviewed
Oct 5, 2021
|
@killianmuldoon Can you please resolve the resolved conversations/findings for a better overview? Thank you |
killianmuldoon
force-pushed
the
pr-clusterclass-quickstart-guide
branch
from
f75e7bf to
0258a82
Compare
sbueringer
reviewed
Oct 5, 2021
k8s-ci-robot
added
size/L
killianmuldoon
force-pushed
the
pr-clusterclass-quickstart-guide
branch
from
34cbfa0 to
72c16f1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| - Install [Kind] and [Docker] | ||
|
|
||
| ClusterClass is currently behind a feature gate that needs to be enabled. | ||
| This tutorial will also use another experimental gated feature - Cluster Resource Set - in this tutorial. This is not required for ClusterClass but is used in this tutorial to set up networking. |
There was a problem hiding this comment.
Suggested change
| This tutorial will also use another experimental gated feature - Cluster Resource Set - in this tutorial. This is not required for ClusterClass but is used in this tutorial to set up networking. | |
| This tutorial will also use another experimental gated feature - Cluster Resource Set -. This is not required for ClusterClass but is used in this tutorial to set up networking. |
k8s-ci-robot
removed
the
lgtm
|
lgtm pending squash |
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
pr-clusterclass-quickstart-guide
branch
from
5af66fa to
233f070
Compare
|
Squashed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add a simple quick start guide to the CAPI book under experimental features. The guide shows how to create and then update a CAPD cluster from Kind install through to deletion using ClusterClass and Managed Topologies.
Fixes #5368
Signed-off-by: killianmuldoon [email protected]