📖 Add clusterclass contract changes to v1alpha3-v1alpha4 conversion guide #5366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
killianmuldoon
commented
Sep 30, 2021
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
pr-update-conversion-docs
branch
2 times, most recently
from
4e2d5cb to
82fd238
Compare
sbueringer
reviewed
Oct 1, 2021
killianmuldoon
force-pushed
the
pr-update-conversion-docs
branch
from
82fd238 to
640c8e6
Compare
|
|
||
| `status.version` - is a string representing the minimum Kubernetes version for the control plane machines in the cluster. | ||
|
|
||
| These fields are a requirement for ClusterClass compatibility. |
There was a problem hiding this comment.
Suggested change
| These fields are a requirement for ClusterClass compatibility. | |
| Please note that implementing those field is a requirement for a control plane provider to be used with ClusterClass and managed topologies. |
| `machineTemplate` - is a struct containing details of the control plane | ||
| machine template. | ||
|
|
||
| This field is a requirement for ClusterClass compatibility. |
There was a problem hiding this comment.
Suggested change
| This field is a requirement for ClusterClass compatibility. | |
| Please note that implementing those field for control plane providers using machines is a requirement for ClusterClass and managed topologies to work consistently across all the providers. |
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
pr-update-conversion-docs
branch
from
640c8e6 to
bbc8384
Compare
|
@fabriziopandini @sbueringer updated now. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to include some changes made to the ControlPlane contract to support ClusterClass.
Signed-off-by: killianmuldoon [email protected]
Fixes #5282