Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update v1alpha3->alpha4 conversion guide with recent contract revisions #5282

Closed
killianmuldoon opened this issue Sep 21, 2021 · 5 comments · Fixed by #5366
Closed

Update v1alpha3->alpha4 conversion guide with recent contract revisions #5282

killianmuldoon opened this issue Sep 21, 2021 · 5 comments · Fixed by #5366
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Milestone
v0.4

Comments

@killianmuldoon
Copy link
Contributor

Detailed Description
This task involves updating the CAPI book's v1alpha3-v1alpha4 conversion guide to include recent changes in the CAPI contract.

As per #5264 (comment) changes made over the course of a release - e.g. clusterClass motivated changes to the CAPI contract made during v1alpha4 - should be included in the correct conversion documentation in the CAPI book where they impact providers.

Two specific changes,

#4949 on v1alpha3 -> v1alpha4 doc + the need of implementing InfrastructureClusterTemplate or ControlPlaneTemplate for ClusterClass support

are highlighted here, but there may be more to document on reviewing the CAPI changes over the full lifetime of v1apha4.

https://cluster-api.sigs.k8s.io/developer/providers/v1alpha3-to-v1alpha4.html
@sbueringer
Copy link
Member

Probably makes sense to cherry-pick to release-0.4 for the release-0.4 book

@killianmuldoon killianmuldoon mentioned this issue Sep 22, 2021
Closed
@vincepri
Copy link
Member

@killianmuldoon Are you able to open a PR to tackle the above?

@vincepri
Copy link
Member

/milestone v0.4

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Sep 30, 2021
@vincepri
Copy link
Member

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 30, 2021
@killianmuldoon
Copy link
Contributor Author

killianmuldoon commented Sep 30, 2021 •
edited
Loading

@killianmuldoon Are you able to open a PR to tackle the above?

@vincepri
Will do today.

@killianmuldoon killianmuldoon mentioned this issue Sep 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Milestone
v0.4
4 participants
@vincepri @sbueringer @k8s-ci-robot @killianmuldoon