Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Deprecate unused MachineDeployment constants #5241

Merged
merged 1 commit into from
Sep 15, 2021
Merged

🌱 Deprecate unused MachineDeployment constants #5241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions controllers/mdutil/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,24 @@ const (
DefaultMachineDeploymentUniqueLabelKey = "machine-template-hash"

// FailedMSCreateReason is added in a machine deployment when it cannot create a new machine set.
// Deprecated: This field will be removed in a next release.
FailedMSCreateReason = "MachineSetCreateError"

// FoundNewMSReason is added in a machine deployment when it adopts an existing machine set.
// Deprecated: This field will be removed in a next release.
FoundNewMSReason = "FoundNewMachineSet"

// PausedDeployReason is added in a deployment when it is paused. Lack of progress shouldn't be
// estimated once a deployment is paused.
// Deprecated: This field will be removed in a next release.
PausedDeployReason = "DeploymentPaused"

// MinimumReplicasAvailable is added in a deployment when it has its minimum replicas required available.
// Deprecated: This field will be removed in a next release.
MinimumReplicasAvailable = "MinimumReplicasAvailable"
// MinimumReplicasUnavailable is added in a deployment when it doesn't have the minimum required replicas
// available.
// Deprecated: This field will be removed in a next release.
MinimumReplicasUnavailable = "MinimumReplicasUnavailable"
)

Expand Down