🌱 Deprecate unused MachineDeployment constants #5241
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
Do we have to deprecate the constants first and then drop them with v1beta1? |
Not sure in this case it seems they have never been exposed by us in any way so they should have never been able to be consumed in any way but may be I'm missing something. |
|
This is a breaking change, we should probably deprecate these first and remove them once we cut the next release |
enxebre
force-pushed
the
remove-constants
branch
from
b104496 to
2ae8f06
Compare
|
/retitle 🌱 Deprecate unused MachineDeployment constants |
k8s-ci-robot
changed the title
enxebre
force-pushed
the
remove-constants
branch
from
2ae8f06 to
6d52909
Compare
k8s-ci-robot
added
size/XS
controllers/mdutil/util.go
Outdated
| @@ -44,17 +44,24 @@ const ( | |||
| DefaultMachineDeploymentUniqueLabelKey = "machine-template-hash" | |||
|
|
|||
| // FailedMSCreateReason is added in a machine deployment when it cannot create a new machine set. | |||
| // Deprecated | |||
There was a problem hiding this comment.
| // Deprecated | |
| // Deprecated: This field will be removed in a next release. |
nit
Looks like we usually write either use another field/func or this will be removed.
|
Updated to deprecate them. Just to get full context this is technically breaking change but there's no way this can break anyone right? or am I missing something? |
This was first added here kubernetes-sigs#143 and it's never been used.
enxebre
force-pushed
the
remove-constants
branch
from
6d52909 to
ca7e71b
Compare
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@enxebre They seem leftovers, it should be fine to remove them |
What this PR does / why we need it:
This was first added here #143 and it's never been used.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #