🐛 fix flaky TestPatchHelper test #5215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
vincepri
reviewed
Sep 7, 2021
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-fix-flakey-patch-test
branch
from
efe4335 to
18dc650
Compare
k8s-ci-robot
added
size/M
|
I adjusted all tests in this file accordingly. When easily possible I tried to return the condition in |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes the two flaky test cases in
TestPatchHelper(which are two of the most frequent ones we have right now).The test assumes that the condition we have in the local object is exactly the same compared to the condition after the patch on the server-side. This is not true, because the patch helper re-calculates the
LastTransitionTimeduring the patch func. In theory there are a few more test cases which should be affected. According to testgrid only those two are flaky.Q:
LastTransitionTime)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #