fix flaky TestPatchHelper tests

Signed-off-by: Stefan Büringer [email protected]
kubernetes-sigs · Sep 7, 2021 · efe4335 · efe4335
1 parent 2798730
commit efe4335
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/util/patch/patch_test.go b/util/patch/patch_test.go
@@ -425,6 +425,10 @@ func TestPatchHelper(t *testing.T) {
 					readyBefore := conditions.Get(obj, clusterv1.ReadyCondition)
 					readyAfter := conditions.Get(objAfter, clusterv1.ReadyCondition)
 
+					// Differences in the LastTransitionTime are intentionally ignored as the LastTransitionTime is re-calculated
+					// in conditions.Set during patch.Helper.Patch() and thus not necessarily equal to the one in the original obj.
+					readyBefore.LastTransitionTime = readyAfter.LastTransitionTime
+
 					return cmp.Equal(readyBefore, readyAfter)
 				}, timeout).Should(BeTrue())
 			})
@@ -476,6 +480,10 @@ func TestPatchHelper(t *testing.T) {
 					readyBefore := conditions.Get(obj, clusterv1.ReadyCondition)
 					readyAfter := conditions.Get(objAfter, clusterv1.ReadyCondition)
 
+					// Differences in the LastTransitionTime are intentionally ignored as the LastTransitionTime is re-calculated
+					// in conditions.Set during patch.Helper.Patch() and thus not necessarily equal to the one in the original obj.
+					readyBefore.LastTransitionTime = readyAfter.LastTransitionTime
+
 					return cmp.Equal(readyBefore, readyAfter)
 				}, timeout).Should(BeTrue())
 			})