🌱 KubeadmControlPlane internal/proxy should use pointer structs

controlplane/kubeadm/internal/proxy/addr.go

@@ -51,7 +51,7 @@ func (a Addr) String() string {
 }
 
 // NewAddrFromConn creates an Addr from the given connection.
-func NewAddrFromConn(c Conn) Addr {
+func NewAddrFromConn(c *Conn) Addr {
 	return Addr{
 		port:       c.stream.Headers().Get(corev1.PortHeader),
 		identifier: c.stream.Identifier(),

controlplane/kubeadm/internal/proxy/conn.go

@@ -33,40 +33,40 @@ type Conn struct {
 }
 
 // Read from the connection.
-func (c Conn) Read(b []byte) (n int, err error) {
+func (c *Conn) Read(b []byte) (n int, err error) {
 	return c.stream.Read(b)
 }
 
 // Close the underlying proxied connection.
-func (c Conn) Close() error {
+func (c *Conn) Close() error {
 	return kerrors.NewAggregate([]error{c.stream.Close(), c.connection.Close()})
 }
 
 // Write to the connection.
-func (c Conn) Write(b []byte) (n int, err error) {
+func (c *Conn) Write(b []byte) (n int, err error) {
 	return c.stream.Write(b)
 }
 
 // LocalAddr returns a fake address representing the proxied connection.
-func (c Conn) LocalAddr() net.Addr {
+func (c *Conn) LocalAddr() net.Addr {
 	return NewAddrFromConn(c)
 }
 
 // RemoteAddr returns a fake address representing the proxied connection.
-func (c Conn) RemoteAddr() net.Addr {
+func (c *Conn) RemoteAddr() net.Addr {
 	return NewAddrFromConn(c)
 }
 
 // SetDeadline sets the read and write deadlines to the specified interval.
-func (c Conn) SetDeadline(t time.Time) error {
+func (c *Conn) SetDeadline(t time.Time) error {
 	// TODO: Handle deadlines
 	c.readDeadline = t
 	c.writeDeadline = t
 	return nil
 }
 
 // SetWriteDeadline sets the read and write deadlines to the specified interval.
-func (c Conn) SetWriteDeadline(t time.Time) error {
+func (c *Conn) SetWriteDeadline(t time.Time) error {
 	c.writeDeadline = t
 	return nil
 }
@@ -79,8 +79,8 @@ func (c Conn) SetReadDeadline(t time.Time) error {
 
 // NewConn creates a new net/conn interface based on an underlying Kubernetes
 // API server proxy connection.
-func NewConn(connection httpstream.Connection, stream httpstream.Stream) Conn {
-	return Conn{
+func NewConn(connection httpstream.Connection, stream httpstream.Stream) *Conn {
+	return &Conn{
 		connection: connection,
 		stream:     stream,
 	}