🌱 KubeadmControlPlane internal/proxy should use pointer structs #5161
Conversation
The net.Conn interface doesn't need a plain struct, it can work well with pointers as well. To avoid copying structs around every time we initiate a connection or call a method, convert the underlying Conn struct in the proxy package to using pointer receiving methods. This change also fixes an issue with read/writeDeadline, which was being set in the local copy of the Conn struct before instead of the current object, which created an ineffective assignment. Signed-off-by: Vince Prignano <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
| c.readDeadline = t | ||
| c.writeDeadline = t |
There was a problem hiding this comment.
These assignments were ineffective before this change.
| return NewAddrFromConn(c) | ||
| } | ||
|
|
||
| // SetDeadline sets the read and write deadlines to the specified interval. | ||
| func (c Conn) SetDeadline(t time.Time) error { | ||
| func (c *Conn) SetDeadline(t time.Time) error { | ||
| // TODO: Handle deadlines |
There was a problem hiding this comment.
@randomvariable Can you clarify what needs to be done here?
|
changes lgtm, but triggering all the E2E test to have a stronger signal on this change |
|
/test pull-cluster-api-e2e-full-main Seems unrelated |
|
/test ls |
|
@vincepri: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-workload-upgrade-1-22-latest-main |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-e2e-full-main |
|
I will try again tomorrow morning EU, hoping to have less flakes |
|
/retest |
1 similar comment
|
/retest |
|
/retest |
1 similar comment
|
/retest |
|
The problem is that CAPD panics, fix PR: #5167
I wasn't able to find out why this started to occur yesterday. I couldn't find any related changes. |
|
#5167 just merged |
|
All the test passed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
The net.Conn interface doesn't need a plain struct, it can work well
with pointers as well. To avoid copying structs around every time we
initiate a connection or call a method, convert the underlying Conn
struct in the proxy package to using pointer receiving methods.
This change also fixes an issue with read/writeDeadline, which was being
set in the local copy of the Conn struct before instead of the current
object, which created an ineffective assignment.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/assign @sbueringer @randomvariable @fabriziopandini