Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 e2e tests: make the management cluster Kubernetes version configurable #5081

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partially implements #5078

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 11, 2021
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 11, 2021
@sbueringer sbueringer force-pushed the pr-e2e-test-configurable-mgmt-cluster branch from 80d2df2 to b88eb50 Compare August 12, 2021 04:50
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 12, 2021
test/e2e/common.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 12, 2021
@sbueringer sbueringer force-pushed the pr-e2e-test-configurable-mgmt-cluster branch from 4de93d7 to e804a16 Compare August 12, 2021 17:17
@sbueringer sbueringer changed the title 🌱 e2e tests: make the management cluster image configurable 🌱 e2e tests: make the management cluster Kubernetes version configurable Aug 12, 2021
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending two small nits

scripts/ci-e2e-lib.sh Outdated Show resolved Hide resolved
test/framework/bootstrap/kind_provider.go Outdated Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-e2e-test-configurable-mgmt-cluster branch from e71b497 to 896e927 Compare August 16, 2021 15:31
@sbueringer
Copy link
Member Author

Fixed and updated test-infra PR (https://github.com/kubernetes/test-infra/pull/23228/files) accordingly.

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 17, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1868b9a into kubernetes-sigs:master Aug 17, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Aug 17, 2021
@sbueringer sbueringer deleted the pr-e2e-test-configurable-mgmt-cluster branch August 17, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants