-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Migrate envtest setup to envtest.Run, add CAPI_DISABLE_TEST_ENV option #5030
🌱 Migrate envtest setup to envtest.Run, add CAPI_DISABLE_TEST_ENV option #5030
Conversation
First version to find out if we have consensus on the implementation. After we got that, I would extend the PR to add a few sentences how to:
to: https://cluster-api.sigs.k8s.io/developer/testing.html#running-unit-and-integration-tests |
cec54a4
to
5962c3c
Compare
And now also fixed some nil pointers I missed before :/. At least locally all tests are successful now. @vincepri PTAL :) (I also answered to the remaining open conversations above) |
Let's squash commits |
And retitle the PR 🙃 |
aa4a842
to
6a21abc
Compare
Signed-off-by: Stefan Büringer [email protected]
6a21abc
to
7c9a332
Compare
@vincepri rebased, ajusted commit message, retitled PR. Feel free to retitle, I tried to express the main points and keep it somewhat concise P.S. I assumed that we want to keep |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #5029