✨ create index for cluster.spec.topology.class #4967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
ykakarap
force-pushed
the
clusterclass_cluster_topology_index
branch
from
8d23f74 to
fda6322
Compare
|
/assign @fabriziopandini |
vincepri
reviewed
Jul 20, 2021
sbueringer
reviewed
Jul 20, 2021
|
Changes lgtm (waiting for pending comments) |
k8s-ci-robot
added
the
needs-rebase
|
#4965 is merged, so it now possible to use the new index in the ClusterTopology controller! |
|
Will need to rebase this after #5004 is merged. |
ykakarap
force-pushed
the
clusterclass_cluster_topology_index
branch
from
fda6322 to
253d4e9
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
ykakarap
force-pushed
the
clusterclass_cluster_topology_index
branch
from
253d4e9 to
f873fd0
Compare
|
/retest |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds an index for the
cluster.spec.topology.class.This is to enable efficiently finding clusters that are stamped from a given ClusterClass.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #4931