Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Compute desired Cluster and its referenced objects for a managed topology #5002

Merged
merged 1 commit into from
Aug 9, 2021
Merged

🌱 Compute desired Cluster and its referenced objects for a managed topology #5002

merged 1 commit into from
Aug 9, 2021
+889 −24

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:

This is part of the activities for the implementation of the ClusterClass proposal.

This PR computes the desired state for the Cluster and its referenced objects.

WIP: this PR is based on #4986; please consider only the last commit

Which issue(s) this PR fixes:
Fixes #4998

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 22, 2021
This was referenced Jul 22, 2021
Closed
Merged
sbueringer
sbueringer reviewed Jul 23, 2021
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!!
Only nits. I would give it another review after the two underlying PRs have been merged.

controllers/clustertopology_controller_compute.go Outdated Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Outdated Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Outdated Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Outdated Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Outdated Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Outdated Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Outdated Show resolved Hide resolved
controllers/clustertopology_controller_compute.go Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2021
@fabriziopandini fabriziopandini force-pushed the cluster-class-compute-part1 branch from 84db72c to 877f5d9 Compare July 27, 2021 12:40
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2021
@sbueringer
Copy link
Member

lgtm apart from the one TODO after #4991 is merged

@fabriziopandini fabriziopandini force-pushed the cluster-class-compute-part1 branch from 877f5d9 to ae92a85 Compare July 28, 2021 13:27
@fabriziopandini fabriziopandini changed the title [WIP] 🌱 Compute desired Cluster and its referenced objects for a managed topology 🌱 Compute desired Cluster and its referenced objects for a managed topology Jul 28, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 28, 2021
@fabriziopandini
Copy link
Member Author

@sbueringer TODO addressed
@vincepri this one should be ready to go...

sbueringer
sbueringer reviewed Jul 28, 2021
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabriziopandini one nit

controllers/clustertopology_controller_compute_test.go Outdated Show resolved Hide resolved
@ykakarap ykakarap mentioned this pull request Jul 29, 2021
Closed
@fabriziopandini fabriziopandini force-pushed the cluster-class-compute-part1 branch from ae92a85 to 1d23a8a Compare July 29, 2021 20:58
@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 29, 2021
@fabriziopandini fabriziopandini force-pushed the cluster-class-compute-part1 branch from 1d23a8a to 09b87ae Compare August 2, 2021 18:57
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 2, 2021
@fabriziopandini
Copy link
Member Author

rebased...

@fabriziopandini fabriziopandini force-pushed the cluster-class-compute-part1 branch from 09b87ae to 3f22087 Compare August 3, 2021 08:34
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-test-main

@fabriziopandini
Copy link
Member Author

/retest

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2021
@sbueringer sbueringer mentioned this pull request Aug 9, 2021
Closed
vincepri
vincepri approved these changes Aug 9, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8e61e26 into kubernetes-sigs:master Aug 9, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Aug 9, 2021
@fabriziopandini fabriziopandini deleted the cluster-class-compute-part1 branch August 10, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Implement generate Cluster and its referenced objects for a managed topology
4 participants
@fabriziopandini @sbueringer @k8s-ci-robot @vincepri