🌱 Align ClusterClass ControlPlane with the rest of the fields

[vincepri]

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

This commits introduces ControlPlaneClass and allows users to set
metadata fields for all control plane objects. It also adds fields to
set infrastructure reference for Machine objects and clarifies what
contracts the field expects from the control plane provider.

NOTE: While this is technically a breaking change, it's a follow-up to #4928.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/assign @fabriziopandini @CecileRobertMichon

[vincepri]

@CecileRobertMichon @sbueringer @fabriziopandini This should be good to go

[sbueringer]

/lgtm

[ykakarap]

I am probably missing something but the LocalObjectTemplate we have here refs to a ControlPlaneTemplate (Ex: KubeadmControlPlaneTemplate - will be introduced in #4904 ).

This ControlPlaneTemplate will internally refer to a machine infrastructure, isnt it?
Going back the kcp template example we have a machine infra ref at kcptemplate.spec.template.spec.machineTemplate.infrastructureRef. How is this different from the new MachineInfrastructure field?

[sbueringer]

Imho both will reference the same InfrastructureMachineTemplate. This PR makes it explicit on the ClusterClass (i.e. you have to set the ref on the ClusterClass and inside the ControlPlaneTemplate)

[fabriziopandini]

Exactly, we are making this explicit;
Also, according to the initial work on #5002, ClusterClass is always going to set the reference inside the ControlPlaneTemplate, so it is not required to set it in both places upfront

[sbueringer]

Good that fits for my PR as I assume that the ref can be unset in the ControlPlane even if it is set in the ClusterClass.

[ykakarap]

ClusterClass is always going to set the reference inside the ControlPlaneTemplate, so it is not required to set it in both places upfront

Good to know that we are doing this, however the kcptemplate.spec.template.spec.machineTemplate.infrastructureRef is not an optional field. So are we expecting that the user set the filed both inside the ControlPlaneTemplate and inside the ClusterClass definition and also that both the fields point to the same thing?
We should throw an error incase they dont match, is it?

[fabriziopandini]

/lgtm

[vincepri]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/retest

[k8s-ci-robot]

@vincepri: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
pull-cluster-api-apidiff-main	509daea	link	/test pull-cluster-api-apidiff-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.