Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Allow e2e tests to install more than one infra provider #4791

Merged
merged 1 commit into from
Jun 23, 2021
Merged

🌱 Allow e2e tests to install more than one infra provider #4791

merged 1 commit into from
Jun 23, 2021

Conversation

anusha94
Copy link
Contributor

We are developing a new provider, and we would like to use CAPD and our provider together in the E2E tests while our provider is still Work in Progress.

We reuse the Cluster API e2e tests in our code so as to avoid duplication.

What this PR does / why we need it:
Fixes #4790

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
  • Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 10, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @anusha94!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @anusha94. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 10, 2021
@anusha94 anusha94 force-pushed the gt_one_infra_provider branch from 7dcbd83 to 2d701c5 Compare June 10, 2021 07:06
@palnabarun
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 10, 2021
@anusha94 anusha94 force-pushed the gt_one_infra_provider branch 3 times, most recently from a7472af to 5e20551 Compare June 10, 2021 08:29
fabriziopandini
fabriziopandini reviewed Jun 10, 2021
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anusha94 welcome on Cluster API!
Please sign the CLA and make sure your affiliation is properly assigned (instructions above); let me know if you have problems.

lgtm apart a super small nit

test/framework/clusterctl/e2e_config.go Outdated
if len(providersByType[clusterctlv1.InfrastructureProviderType]) != 1 {
return errInvalidArg("invalid config: it is required to have exactly one infrastructure-provider")
if len(providersByType[clusterctlv1.InfrastructureProviderType]) < 1 {
return errInvalidArg("invalid config: it is required to have atleast one infrastructure-provider")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return errInvalidArg("invalid config: it is required to have atleast one infrastructure-provider")
return errInvalidArg("invalid config: it is required to have at least one infrastructure-provider")

@anusha94
Copy link
Contributor Author

/check-cla

1 similar comment
@jamiemonserrate
Copy link
Contributor

/check-cla

@jamiemonserrate jamiemonserrate force-pushed the gt_one_infra_provider branch from 89bb4d3 to cd24806 Compare June 18, 2021 03:17
@fabriziopandini
Copy link
Member

/check-cla
lgtm pending squash

@anusha94 anusha94 force-pushed the gt_one_infra_provider branch 5 times, most recently from b17acc8 to 83b0c7c Compare June 22, 2021 15:03
@randomvariable
Copy link
Member

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 23, 2021
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2021
@anusha94 @jamiemonserrate
Allow e2e tests to install more than one infra provider
d6b31bb 
we are developing a new provider,  and we would like to use CAPD and our provider together in the E2E tests while our provider is still WIP

Co-authored-by: Jamie Monserrate <[email protected]>
@anusha94 anusha94 force-pushed the gt_one_infra_provider branch from 83b0c7c to d6b31bb Compare June 23, 2021 09:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2021
@randomvariable
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 23, 2021
@anusha94
Copy link
Contributor Author

/test pull-cluster-api-test-main

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7f879be into kubernetes-sigs:master Jun 23, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 23, 2021
@anusha94 anusha94 mentioned this pull request Dec 3, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@randomvariable randomvariable

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Allow more than 1 InfrastructureProvider to be installed in e2e tests
6 participants
@anusha94 @k8s-ci-robot @palnabarun @jamiemonserrate @fabriziopandini @randomvariable