Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more than 1 InfrastructureProvider to be installed in e2e tests #4790

Closed
anusha94 opened this issue Jun 10, 2021 · 1 comment · Fixed by #4791
Closed

Allow more than 1 InfrastructureProvider to be installed in e2e tests #4790

anusha94 opened this issue Jun 10, 2021 · 1 comment · Fixed by #4791
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@anusha94
Copy link
Contributor

User Story

As a developer I would like to be able to install multiple infrastructure providers as part of the e2e tests so that I can test a cluster that is spun up using multiple providers.

Detailed Description
The e2e_config forces exactly one infrastructure provider to be run as part of tests https://github.com/kubernetes-sigs/cluster-api/blob/master/test/framework/clusterctl/e2e_config.go#L484-L487.

We would like to relax this assertion to allow more than 1 provider.

We are building a new infrastructure provider, and want to use the docker provider for the control plane, and our new provider for the worker nodes. We are also trying to reuse the e2e setup from this repo, to reduce duplication.

We will post a PR for this shortly. Please let us know if you think this change is acceptable.

Thanks,
Anusha & @jamiemonserrate

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 10, 2021
@fabriziopandini
Copy link
Member

Happy to see new use case for our test framework!
/area testing

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Jun 10, 2021
@fabriziopandini fabriziopandini added this to the v0.4 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants