Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Kubernetes 1.22 support - bump etcd client v3.5.0 #4769

Merged
merged 1 commit into from
Jun 16, 2021
Merged

🌱 Kubernetes 1.22 support - bump etcd client v3.5.0 #4769

merged 1 commit into from
Jun 16, 2021

Conversation

randomvariable
Copy link
Member

@randomvariable randomvariable commented Jun 8, 2021 •
edited
Loading

Signed-off-by: Naadir Jeewa [email protected]

What this PR does / why we need it:

Kubernetes v1.22 has bumped the etcd client to v3.5.0 and should be safe to do so in CAPI.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #4745

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 8, 2021
@randomvariable
Copy link
Member Author

v3.5.0 moves to the new go module format in the repo, which is why i've not bothered with v3.4.x

@CecileRobertMichon
Copy link
Contributor

Not sure we want to include a release candidate in our release? Might be better to wait for the actual release to bump?

@randomvariable
Copy link
Member Author

Sure. I'll keep the PR open as WIP, and then when etcd releases, I'll update.

@randomvariable randomvariable changed the title Bump etcd to v3.5.0-rc.0 release candidate [wip] Bump etcd to v3.5.0-rc.0 release candidate Jun 8, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2021
vincepri
vincepri reviewed Jun 8, 2021
View reviewed changes
go.mod Show resolved Hide resolved
@randomvariable randomvariable mentioned this pull request Jun 8, 2021
Merged
@randomvariable
Copy link
Member Author

/reopen
/retitle [wip] Kubernetes v1.22 support - Bump etcd client to v3.5.0
/hold

@k8s-ci-robot k8s-ci-robot changed the title [wip] Bump etcd to v3.5.0-rc.0 release candidate [wip] Kubernetes v1.22 support - Bump etcd client to v3.5.0 Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2021
@k8s-ci-robot k8s-ci-robot reopened this Jun 9, 2021
@k8s-ci-robot
Copy link
Contributor

@randomvariable: Reopened this PR.

In response to this:

/reopen
/retitle [wip] Kubernetes v1.22 support - Bump etcd client to v3.5.0
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@randomvariable randomvariable force-pushed the etcd-bump-v3-5 branch 2 times, most recently from f36feba to 659e97d Compare June 16, 2021 10:22
@randomvariable randomvariable changed the title [wip] Kubernetes v1.22 support - Bump etcd client to v3.5.0 Kubernetes v1.22 support - Bump etcd client to v3.5.0 Jun 16, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2021
Bump etcd to v3.5.0
f1da11e 
Signed-off-by: Naadir Jeewa <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 16, 2021
@randomvariable
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2021
@randomvariable
Copy link
Member Author

/retest

vincepri
vincepri approved these changes Jun 16, 2021
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/retitle 🌱 Kubernetes 1.22 support - bump etcd client v3.5.0
/assign @CecileRobertMichon

@k8s-ci-robot k8s-ci-robot changed the title Kubernetes v1.22 support - Bump etcd client to v3.5.0 🌱 Kubernetes 1.22 support - bump etcd client v3.5.0 Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2021
@vincepri
Copy link
Member

/test ls

@k8s-ci-robot
Copy link
Contributor

@vincepri: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-make-main
  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-verify
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-e2e-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

Use /test all to run the following jobs:

  • pull-cluster-api-build-main
  • pull-cluster-api-apidiff-main
  • pull-cluster-api-verify
  • pull-cluster-api-test-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-e2e-ipv6-main

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-workload-upgrade-1-21-latest-main

CecileRobertMichon
CecileRobertMichon reviewed Jun 16, 2021
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2021
@k8s-ci-robot k8s-ci-robot merged commit 86466a1 into kubernetes-sigs:master Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@vincepri vincepri

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.4
Development

Successfully merging this pull request may close these issues.

Update etcd client dependency
4 participants
@randomvariable @CecileRobertMichon @k8s-ci-robot @vincepri