Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update etcd client dependency #4745

Closed
randomvariable opened this issue Jun 7, 2021 · 14 comments · Fixed by #4769 or #4823
Closed

Update etcd client dependency #4745

randomvariable opened this issue Jun 7, 2021 · 14 comments · Fixed by #4769 or #4823
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Milestone

Comments

@randomvariable
Copy link
Member

randomvariable commented Jun 7, 2021

User Story

The etcd client dependency is very outdated, and we're missing grpc fixes as a result. Need to refactor the cluster etcd client to make use of v3.4.16.

Detailed Description

[A clear and concise description of what you want to happen.]

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 7, 2021
@vincepri
Copy link
Member

vincepri commented Jun 7, 2021

@randomvariable Could we do this before v0.4.0?

@randomvariable
Copy link
Member Author

I wasn't sure how big a change it was going to be. I'll review and get an answer today.

@randomvariable
Copy link
Member Author

Just checked. There's nothing we can do here because Kubernetes depends on the older etcd client, which might be because it's stuck on an old grpc version because of cadvisor.

So

/close

@k8s-ci-robot
Copy link
Contributor

@randomvariable: Closing this issue.

In response to this:

Just checked. There's nothing we can do here because Kubernetes depends on the older etcd client, which might be because it's stuck on an old grpc version because of cadvisor.

So

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@randomvariable
Copy link
Member Author

The network of dependencies is:
sigs.k8s.io/[email protected] k8s.io/[email protected]
k8s.io/[email protected] google.golang.org/[email protected]

Work is ongoing in kubernetes/kubernetes#102061 to update that.

@randomvariable
Copy link
Member Author

Only pulling in apiextensions-apiserver to bring in the struct for CustomResourceDefinition... potentially removable.

@randomvariable
Copy link
Member Author

/reopoen

figured it out.

@randomvariable
Copy link
Member Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 8, 2021
@k8s-ci-robot
Copy link
Contributor

@randomvariable: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

vincepri commented Jun 8, 2021

/milestone v0.4

Let's bump it once v3.5 is released and we can validate it a bit more

@k8s-ci-robot k8s-ci-robot added this to the v0.4 milestone Jun 8, 2021
@randomvariable
Copy link
Member Author

randomvariable commented Jun 9, 2021

I had a look at the milestone planning for etcd, their plan is to get the release out once they have signal from k/k to accept it for 1.22, so probably will be a v0.4.x thing. As far as I can tell, there's a performance issue to resolve first.

@vincepri
Copy link
Member

/reopen

@k8s-ci-robot
Copy link
Contributor

@vincepri: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

/kind release-blocking

@k8s-ci-robot k8s-ci-robot reopened this Jun 16, 2021
@k8s-ci-robot k8s-ci-robot added the kind/release-blocking Issues or PRs that need to be closed before the next CAPI release label Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. kind/release-blocking Issues or PRs that need to be closed before the next CAPI release
Projects
None yet
3 participants