-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove v1beta1 type and switch v1alpha3 to use v1beta2 #4623
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@gab-satchi: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Aren't we switching v1alpha4 to v1beta2? |
@@ -19,7 +19,7 @@ package v1alpha3 | |||
import ( | |||
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
clusterv1 "sigs.k8s.io/cluster-api/api/v1alpha3" | |||
kubeadmv1beta1 "sigs.k8s.io/cluster-api/bootstrap/kubeadm/types/v1beta1" | |||
kubeadmv1beta2 "sigs.k8s.io/cluster-api/bootstrap/kubeadm/types/v1beta2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gab-satchi
I feel really bad about this because I opened the issue behind this PR, but now that I see that removing v1beta1 is impacting v1alpha3 I don't think we can move on with this change, otherwise we can't ensure a clean v1alpha3 --> v1alpha4 upgrade.
This change has to wait for v1alpha3 being removed before 😞
Sorry again for not having considered this when opening the issue
/hold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably mostly drop support / deprecate in this release, rather than removing the APIs altogether. In the next release, we should be able to proceed with the complete removal, alongside the v1alpha3 API types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries @fabriziopandini. let me know if it makes more sense to close and re-open when the time is right
closing until v1alpha3 is removed /close |
@gab-satchi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #4507
holding until #4445 is implemented
/hold